Re: RFR 8149790: NegativeArraySizeException with hprof

Thanks Christian. -George On 8/15/2017 4:28 PM, Christian Tornqvist wrote: Hi George, This looks good. Thanks, Christian On Aug 14, 2017, at 11:31 AM, George Triantafillou > wrote: Please review this change to fix NegativeArraySizeException test fa

Re: RFR 8149790: NegativeArraySizeException with hprof

Hi George, This looks good. Thanks, Christian > On Aug 14, 2017, at 11:31 AM, George Triantafillou > wrote: > > Please review this change to fix NegativeArraySizeException test failures > with hprof: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8149790 >

Re: RFR 8149790: NegativeArraySizeException with hprof

Hi Lois, Thanks for the review. I'll update the copyrights. -George On 8/14/2017 4:08 PM, Lois Foltan wrote: George, I think this looks good. Copyright needs updating in FileReadBuffer.java, MappedReadBuffer.java & ReadBuffer.java. Thanks, Lois On 8/14/2017 11:31 AM, George Triantafillo

Re: RFR 8149790: NegativeArraySizeException with hprof

George, I think this looks good. Copyright needs updating in FileReadBuffer.java, MappedReadBuffer.java & ReadBuffer.java. Thanks, Lois On 8/14/2017 11:31 AM, George Triantafillou wrote: Please review this change to fix NegativeArraySizeException test failures with hprof: JBS: https://bug

RFR 8149790: NegativeArraySizeException with hprof

Please review this change to fix NegativeArraySizeException test failures with hprof: JBS: https://bugs.openjdk.java.net/browse/JDK-8149790 webrev: http://cr.openjdk.java.net/~gtriantafill/8149790-webrev/webrev/index.html

Re: RFR: 8149790: NegativeArraySizeException with hprof

Hi, Could I get a Reviewer to take a look at this please? - Andreas On 2016-04-21 19:35, Andreas Eriksson wrote: On 2016-04-21 18:46, Erik Gahlin wrote: On 2016-04-21 15:47, Andreas Eriksson wrote: Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do y

Re: RFR: 8149790: NegativeArraySizeException with hprof

On 2016-04-21 18:46, Erik Gahlin wrote: On 2016-04-21 15:47, Andreas Eriksson wrote: Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do you really need curly braces in the switch clauses? In JavaValueArray.java they were needed before my change but not

Re: RFR: 8149790: NegativeArraySizeException with hprof

On 2016-04-21 15:47, Andreas Eriksson wrote: Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do you really need curly braces in the switch clauses? In JavaValueArray.java they were needed before my change but not after. Do you want me to remove them? In

Re: RFR: 8149790: NegativeArraySizeException with hprof

Hi, On 2016-04-15 20:21, Erik Gahlin wrote: Looks good, not a Reviewer. Thanks. Do you really need curly braces in the switch clauses? In JavaValueArray.java they were needed before my change but not after. Do you want me to remove them? In JavaObject.java they are needed because the 'v

Re: RFR: 8149790: NegativeArraySizeException with hprof

Looks good, not a Reviewer. Do you really need curly braces in the switch clauses? Erik On 2016-04-15 16:40, Andreas Eriksson wrote: Hi, Please review this test fix for 8149790: NegativeArraySizeException with hprof https://bugs.openjdk.java.net/browse/JDK-8149790 http://cr.openjdk.java.ne

RFR: 8149790: NegativeArraySizeException with hprof

Hi, Please review this test fix for 8149790: NegativeArraySizeException with hprof https://bugs.openjdk.java.net/browse/JDK-8149790 http://cr.openjdk.java.net/~aeriksso/8149790/webrev.00/ Changes are to the hprof verifier, which now will pass heap dump content around as JavaThing arrays inst