Re: RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-03 Thread Robbin Ehn
Thanks Staffan! /Robbin On 06/03/2016 09:20 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 2 juni 2016, at 11:41, Robbin Ehn wrote: Hi Dmitry, thanks for looking at this. On 06/01/2016 07:59 PM, Dmitry Samersoff wrote: Robbin, ProcessArgumentMatcher.java:61 What is the re

Re: RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-03 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 2 juni 2016, at 11:41, Robbin Ehn wrote: > > Hi Dmitry, thanks for looking at this. > > On 06/01/2016 07:59 PM, Dmitry Samersoff wrote: >> Robbin, >> >> ProcessArgumentMatcher.java:61 >> >>What is the reason of keeping singlePid as a string. It might be

Re: RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-02 Thread Robbin Ehn
Thanks Dmitry! /Robbin On 06/02/2016 03:48 PM, Dmitry Samersoff wrote: Robbin, The fix looks good for me. -Dmitry On 2016-06-02 09:41, Robbin Ehn wrote: Hi Dmitry, thanks for looking at this. On 06/01/2016 07:59 PM, Dmitry Samersoff wrote: Robbin, ProcessArgumentMatcher.java:61 What

Re: RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-02 Thread Dmitry Samersoff
Robbin, The fix looks good for me. -Dmitry On 2016-06-02 09:41, Robbin Ehn wrote: > Hi Dmitry, thanks for looking at this. > > On 06/01/2016 07:59 PM, Dmitry Samersoff wrote: >> Robbin, >> >> ProcessArgumentMatcher.java:61 >> >> What is the reason of keeping singlePid as a string. It might

Re: RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-02 Thread Robbin Ehn
Hi Dmitry, thanks for looking at this. On 06/01/2016 07:59 PM, Dmitry Samersoff wrote: Robbin, ProcessArgumentMatcher.java:61 What is the reason of keeping singlePid as a string. It might be better to convert it to Long at the argument processing time and then deal with Long. VirtualMach

Re: RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-01 Thread Dmitry Samersoff
Robbin, ProcessArgumentMatcher.java:61 What is the reason of keeping singlePid as a string. It might be better to convert it to Long at the argument processing time and then deal with Long. Arguments.java: null seems more natural to me than "0" JInfo.java: 54 value of flag is not ob

RFR: 8156537: Tools using MonitoredVmUtil do not parse module in cmdline correctly

2016-06-01 Thread Robbin Ehn
Hi all, There were some ripple effects, so to get everything working as intended the patch grow slightly. Webrev: http://cr.openjdk.java.net/~rehn/8156537/01/webrev/ Bug: https://bugs.openjdk.java.net/browse/JDK-8156537 Both a lot of manual testing, the new tests and jdk/test/sun/tools/,jdk/t