Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v11]

2021-01-22 Thread Serguei Spitsyn
On Wed, 23 Dec 2020 18:02:05 GMT, Serguei Spitsyn wrote: >> Thanks for persevering on this one. The updated checks look good. At some >> point I think we re-examine the issue of allowing agents to be non-public, >> maybe emit a warning and eventually disallow it. If/when support is added >>

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v11]

2020-12-23 Thread Serguei Spitsyn
On Wed, 23 Dec 2020 14:06:27 GMT, Alan Bateman wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Prperly reverted fixes in 3 tests; 2. Got rid of term in >> tests summary comment > > Thanks for persevering

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v11]

2020-12-23 Thread Alan Bateman
On Tue, 22 Dec 2020 22:11:19 GMT, Serguei Spitsyn wrote: >> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v11]

2020-12-22 Thread Serguei Spitsyn
On Tue, 22 Dec 2020 23:07:12 GMT, Mandy Chung wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Prperly reverted fixes in 3 tests; 2. Got rid of term in >> tests summary comment > > Thanks for the change.

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v11]

2020-12-22 Thread Mandy Chung
On Tue, 22 Dec 2020 22:11:19 GMT, Serguei Spitsyn wrote: >> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v11]

2020-12-22 Thread Serguei Spitsyn
> This change have been already reviewed by Mandy, Sundar, Alan and David. > Please, see the jdk 15 review thread: > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html > > Now, the PR approval is needed. > The push was postponed because the CSR was not approved