On Wed, 16 Dec 2020 19:44:04 GMT, Mandy Chung wrote:
>> Mandy is correct, the bigger picture here is accessibility. Code in the
>> java.instrument module should be able to invoke the premain or agentmain
>> without needing to suppress access checks. It's a perquisite to supporting
>> the
On Wed, 16 Dec 2020 08:18:49 GMT, Alan Bateman wrote:
> So PR1694 is really just about aligning the spec so that the premain method
> is public. However, it does not fix the overall accessibility issue.
OK I see that JDK-5070281 changes to allow the agent class to be non-public as
the main
On Wed, 16 Dec 2020 08:11:44 GMT, Serguei Spitsyn wrote:
>> Thanks, David!
>> Yes, I was also thinking that the setAccessible has to be remained after all
>> the checks.
>
> I've pushed an update with the following changes:
> - InstrumentationImpl.java update with the process sequence suggested
On Wed, 16 Dec 2020 02:23:33 GMT, Serguei Spitsyn wrote:
>> David, thank you for catching this. I'm probably missing something here.
>> If the agent class is not public then the `m.canAccess(null)` check is not
>> passed and IAE is thrown with the message:
>> `Exception in thread "main"
Hi Mandy,
On 16/12/2020 12:54 pm, Mandy Chung wrote:
On 12/15/20 5:50 PM, David Holmes wrote:
On 16/12/2020 11:35 am, Serguei Spitsyn wrote:
On Wed, 16 Dec 2020 00:50:04 GMT, David Holmes
wrote:
The agent class doesn't have to be public it just has to be accessible.
The premain method
On 12/15/20 5:50 PM, David Holmes wrote:
On 16/12/2020 11:35 am, Serguei Spitsyn wrote:
On Wed, 16 Dec 2020 00:50:04 GMT, David Holmes
wrote:
The agent class doesn't have to be public it just has to be accessible.
The premain method should be queried for public modifier rather than
just
On Wed, 16 Dec 2020 01:32:53 GMT, Serguei Spitsyn wrote:
>> The agent class doesn't have to be public it just has to be accessible.
>>
>> The premain method should be queried for public modifier rather than just
>> relying on a failed invocation request.
>
> David, thank you for catching this.
On 16/12/2020 11:35 am, Serguei Spitsyn wrote:
On Wed, 16 Dec 2020 00:50:04 GMT, David Holmes wrote:
The agent class doesn't have to be public it just has to be accessible.
The premain method should be queried for public modifier rather than just
relying on a failed invocation request.
On Wed, 16 Dec 2020 00:50:04 GMT, David Holmes wrote:
>> Mandy, thank you for the suggestion.
>> I'll retarget the bug and CSR to jdk 17 as nobody is objecting.
>>
>> Also, wanted to make it clear about Exception messages that are provided for
>> two different cases.
>>
>> The test
On Wed, 16 Dec 2020 00:15:36 GMT, Serguei Spitsyn wrote:
>> Alan, David and Many, thank you for the comments!
>> I'll prepare an update according to the recent requests from you.
>> One question is if I need to clone this PR to the JDK 16 fork:
>> https://github.com/openjdk/jdk16
>> It depends
On Mon, 14 Dec 2020 22:45:26 GMT, Serguei Spitsyn wrote:
>> Changes requested by dholmes (Reviewer).
>
> Alan, David and Many, thank you for the comments!
> I'll prepare an update according to the recent requests from you.
> One question is if I need to clone this PR to the JDK 16 fork:
>
On 12/14/20 2:47 PM, Serguei Spitsyn wrote:
On Mon, 14 Dec 2020 02:39:30 GMT, David Holmes wrote:
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
added 8165276 to @bug list of impacted tests
Changes requested by dholmes
On Mon, 14 Dec 2020 02:39:30 GMT, David Holmes wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added 8165276 to @bug list of impacted tests
>
> Changes requested by dholmes (Reviewer).
Alan, David and Many,
On Sat, 12 Dec 2020 09:48:27 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added 8165276 to @bug list of impacted tests
>
>
On Sat, 12 Dec 2020 01:29:28 GMT, Serguei Spitsyn wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David.
>> Please, see the jdk 15 review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>>
>> Now, the PR approval is
On Sat, 12 Dec 2020 01:29:28 GMT, Serguei Spitsyn wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David.
>> Please, see the jdk 15 review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>>
>> Now, the PR approval is
> This change have been already reviewed by Mandy, Sundar, Alan and David.
> Please, see the jdk 15 review thread:
>
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>
> Now, the PR approval is needed.
> The push was postponed because the CSR was not approved
17 matches
Mail list logo
