Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]

2020-12-22 Thread Serguei Spitsyn
On Mon, 21 Dec 2020 20:04:39 GMT, Mandy Chung wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Suppress premain method check only if agent class is in unnamed module; >> 2. minor tests cleanup > > The change

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]

2020-12-21 Thread Serguei Spitsyn
On Mon, 21 Dec 2020 20:04:39 GMT, Mandy Chung wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 1. Suppress premain method check only if agent class is in unnamed module; >> 2. minor tests cleanup > > The change

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]

2020-12-21 Thread Mandy Chung
On Fri, 18 Dec 2020 12:00:48 GMT, Serguei Spitsyn wrote: >> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is

Re: RFR: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs [v9]

2020-12-18 Thread Serguei Spitsyn
> This change have been already reviewed by Mandy, Sundar, Alan and David. > Please, see the jdk 15 review thread: > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html > > Now, the PR approval is needed. > The push was postponed because the CSR was not approved