Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-16 Thread Per Liden
Hi, On 08/16/2018 10:39 AM, Yasumasa Suenaga wrote: Hi, On 2018/08/16 15:55, Per Liden wrote: Hi, On 08/16/2018 03:52 AM, Yasumasa Suenaga wrote: Hi, On 2018/08/15 2:36, Per Liden wrote: Hi, On 2018-08-11 14:06, Yasumasa Suenaga wrote: Hi Per, SA needs memory regions to generate class h

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-16 Thread Yasumasa Suenaga
Hi, On 2018/08/16 15:55, Per Liden wrote: Hi, On 08/16/2018 03:52 AM, Yasumasa Suenaga wrote: Hi, On 2018/08/15 2:36, Per Liden wrote: Hi, On 2018-08-11 14:06, Yasumasa Suenaga wrote: Hi Per, SA needs memory regions to generate class histogram. So it is difficult to use visitor model for

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-15 Thread Per Liden
Hi, On 08/16/2018 03:52 AM, Yasumasa Suenaga wrote: Hi, On 2018/08/15 2:36, Per Liden wrote: Hi, On 2018-08-11 14:06, Yasumasa Suenaga wrote: Hi Per, SA needs memory regions to generate class histogram. So it is difficult to use visitor model for it. I want to back to this issue when clas

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-15 Thread Yasumasa Suenaga
Hi, On 2018/08/15 2:36, Per Liden wrote: Hi, On 2018-08-11 14:06, Yasumasa Suenaga wrote: Hi Per, SA needs memory regions to generate class histogram. So it is difficult to use visitor model for it. I want to back to this issue when class unloading is implemented. If you want to pursue the

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-14 Thread Per Liden
Hi, On 2018-08-11 14:06, Yasumasa Suenaga wrote: Hi Per, SA needs memory regions to generate class histogram. So it is difficult to use visitor model for it. I want to back to this issue when class unloading is implemented. If you want to pursue the path of walking the live set, then you ca

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-11 Thread Yasumasa Suenaga
Hi Per, SA needs memory regions to generate class histogram. So it is difficult to use visitor model for it. I want to back to this issue when class unloading is implemented. Thanks, Yasumasa On 2018/08/08 20:45, Per Liden wrote: Hi, On 08/08/2018 10:34 AM, Yasumasa Suenaga wrote: On 201

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-08 Thread Per Liden
Hi, On 08/08/2018 10:34 AM, Yasumasa Suenaga wrote: On 2018/08/08 17:07, Per Liden wrote: On 08/08/2018 10:02 AM, Per Liden wrote: Hi, On 08/08/2018 10:00 AM, Yasumasa Suenaga wrote: Hi Per, Will class unloading be occurred after relocation? No, before relocation. But it doesn't really

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-08 Thread Yasumasa Suenaga
On 2018/08/08 17:07, Per Liden wrote: On 08/08/2018 10:02 AM, Per Liden wrote: Hi, On 08/08/2018 10:00 AM, Yasumasa Suenaga wrote: Hi Per, Will class unloading be occurred after relocation? No, before relocation. But it doesn't really matter when it happens, since there can still be unre

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-08 Thread Yasumasa Suenaga
ev@openjdk.java.net; zgc-...@openjdk.java.net; hotspot-gc-dev Subject: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working CC'ing to hotspot-gc-dev On 2018/07/26 21:30, Yasumasa Suenaga wrote: PING: Could you review it?    webrev: http://cr.openjdk.java.net/~y

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-08 Thread Per Liden
On 08/08/2018 10:02 AM, Per Liden wrote: Hi, On 08/08/2018 10:00 AM, Yasumasa Suenaga wrote: Hi Per, Will class unloading be occurred after relocation? No, before relocation. But it doesn't really matter when it happens, since there can still be unreachable objects with dead class pointer

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-08 Thread Per Liden
Hi, On 08/08/2018 10:00 AM, Yasumasa Suenaga wrote: Hi Per, Will class unloading be occurred after relocation? No, before relocation. /Per If so, I think we can use this approach. I read the slide [1], it says any garbage does not exist in ZPage after relocation. Thanks, Yasumasa [

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-08 Thread Yasumasa Suenaga
Hi Per, Will class unloading be occurred after relocation? If so, I think we can use this approach. I read the slide [1], it says any garbage does not exist in ZPage after relocation. Thanks, Yasumasa [1] https://www.jfokus.se/jfokus18/preso/ZGC--Low-Latency-GC-for-OpenJDK.pdf On 2018/08

RE: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-07 Thread Sharath Ballal
y AddressRangeShift. Thanks, Sharath -Original Message- From: Yasumasa Suenaga [mailto:yasue...@gmail.com] Sent: Thursday, July 26, 2018 7:22 PM To: serviceability-dev@openjdk.java.net; zgc-...@openjdk.java.net; hotspot-gc-dev Subject: ZGC: RFR: 8207843: HSDB cannot show Object Hi

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-07 Thread Per Liden
Hi, On 08/07/2018 03:02 PM, Yasumasa Suenaga wrote: Hi Per, Currently, class unloading seems not to be implemented. So do not worry about it? Support for class unloading is coming, so this assumption would not hold for very long. cheers, Per http://hg.openjdk.java.net/jdk/jdk/file/10ef3

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-07 Thread Yasumasa Suenaga
Hi Per, Currently, class unloading seems not to be implemented. So do not worry about it? http://hg.openjdk.java.net/jdk/jdk/file/10ef3d870cb7/src/hotspot/share/gc/z/zArguments.cpp#l86 Thanks, Yasumasa On 2018/08/07 21:32, Per Liden wrote: Hi Yasumasa, I'm afraid this approach of iteratin

Re: ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-08-07 Thread Per Liden
Hi Yasumasa, I'm afraid this approach of iterating over objects doesn't work. In ZGC, you can't walk over ZPages since some objects in there might be unreachable and hence might have an invalid/dead class pointer, which in turn means you can't tell the size of the object. When iterating over

ZGC: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-07-26 Thread Yasumasa Suenaga
CC'ing to hotspot-gc-dev On 2018/07/26 21:30, Yasumasa Suenaga wrote: PING: Could you review it?    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8207843/webrev.00/ Yasumasa On 2018/07/19 23:03, Yasumasa Suenaga wrote: Hi all, Please review this webrev.   JBS: https://bugs.open

PING: RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-07-26 Thread Yasumasa Suenaga
PING: Could you review it? webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8207843/webrev.00/ Yasumasa On 2018/07/19 23:03, Yasumasa Suenaga wrote: Hi all, Please review this webrev. JBS: https://bugs.openjdk.java.net/browse/JDK-8207843   webrev: http://cr.openjdk.java.net/~ys

RFR: 8207843: HSDB cannot show Object Histogram when ZGC is working

2018-07-19 Thread Yasumasa Suenaga
Hi all, Please review this webrev. JBS: https://bugs.openjdk.java.net/browse/JDK-8207843 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8207843/webrev.00/ I encountered AssertionFailure when I attached HSDB to the process which is working with ZGC as below: sun.jvm.hotspot.utilities.