Hi Serguei,
On 19/11/2019 2:34 pm, serguei.spit...@oracle.com wrote:
Hi David,
The fix looks good.
Thanks for taking a look!
It is besides the platform-dependent code that Thomas flagged.
There can be similar broken code on other platforms.
For instance, there is a suspicious spot in
Hi David,
The fix looks good.
It is besides the platform-dependent code that Thomas flagged.
There can be similar broken code on other platforms.
For instance, there is a suspicious spot in cpu/ppc/frame_ppc.cpp:
// sender_fp must be within the stack and above (but not
// equal)
Hi Dan,
Thanks for taking a look at this.
On 19/11/2019 3:36 am, Daniel D. Daugherty wrote:
Hi David,
On 11/17/19 9:30 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
Hi David,
On 11/17/19 9:30 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
src/hotspot/share/runtime/thread.hpp
Nice catch!
src/hotspot/share/runtime/thread.cpp
Nice catch!
Not your issue,
Hi David,
On Mon, Nov 18, 2019 at 2:26 PM David Holmes
wrote:
> Hi Thomas,
>
> Thanks for taking a look.
>
> On 18/11/2019 9:58 pm, Thomas Stüfe wrote:
> > This is evil :)
> >
> > There might be more cases like this, e.g.
> >
> > frame_x86.cpp frame::is_interpreted_frame_valid():
> >
> > if
Hi Thomas,
Thanks for taking a look.
On 18/11/2019 9:58 pm, Thomas Stüfe wrote:
This is evil :)
There might be more cases like this, e.g.
frame_x86.cpp frame::is_interpreted_frame_valid():
if (locals > thread->stack_base() || locals < (address) fp()) return false;
Yes that might be a
On 18/11/2019 02:30, David Holmes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
> webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
>
> This was a very difficult bug to track down and I want to publicly
> acknowledge and thank the jemalloc folk (users and developers)
This is evil :)
There might be more cases like this, e.g.
frame_x86.cpp frame::is_interpreted_frame_valid():
if (locals > thread->stack_base() || locals < (address) fp()) return false;
Also, I would have thought the little alloca() dance we do at the start
of thread_native_entry() would push
Thanks Robbin!
David
On 18/11/2019 9:07 pm, Robbin Ehn wrote:
Looks good, thanks David!
/Robbin
On 11/18/19 3:30 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
This was a very difficult bug to track
Looks good, thanks David!
/Robbin
On 11/18/19 3:30 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
This was a very difficult bug to track down and I want to publicly acknowledge
and thank the jemalloc
Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
This was a very difficult bug to track down and I want to publicly
acknowledge and thank the jemalloc folk (users and developers) for
continuing to investigate this issue from
11 matches
Mail list logo
