Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-14 Thread Stefan Karlsson
Thanks, Erik. Stefank On 2019-02-14 09:38, Erik Ă–sterlund wrote: Hi Stefan, Looks good. Thanks, /Erik On 2019-02-11 09:13, Stefan Karlsson wrote: Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to provi

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-14 Thread Erik Ă–sterlund
Hi Stefan, Looks good. Thanks, /Erik On 2019-02-11 09:13, Stefan Karlsson wrote: Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to provide their own implementations. https://cr.openjdk.java.net/~stefank

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-11 Thread Jini George
Hi Stefan, Looks good to me. Thanks, Jini. On 2/11/2019 1:43 PM, Stefan Karlsson wrote: Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to provide their own implementations. https://cr.openjdk.java.net/~

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-11 Thread Stefan Karlsson
Thanks, Jini. StefanK On 2019-02-11 13:00, Jini George wrote: Hi Stefan, Looks good to me. Thanks, Jini. On 2/11/2019 1:43 PM, Stefan Karlsson wrote: Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to p

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-11 Thread Stefan Karlsson
On 2019-02-11 10:39, Aleksey Shipilev wrote: On 2/11/19 9:13 AM, Stefan Karlsson wrote: Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to provide their own implementations. https://cr.openjdk.java.net/~stefank/82

Re: RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-11 Thread Aleksey Shipilev
On 2/11/19 9:13 AM, Stefan Karlsson wrote: > Please review this patch to remove the broken implementation of CollectedHeap > used() and capacity() > and instead force all GCs to provide their own implementations. > > https://cr.openjdk.java.net/~stefank/8218733/webrev.01/ Looks good. > Could y

RFR: 8218733: SA: CollectedHeap provides broken implementation for used() and capacity()

2019-02-11 Thread Stefan Karlsson
Hi all, Please review this patch to remove the broken implementation of CollectedHeap used() and capacity() and instead force all GCs to provide their own implementations. https://cr.openjdk.java.net/~stefank/8218733/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8218733 This was found