Re: RFR: 8221396: Clean up serviceability/sa/TestUniverse.java

2019-03-26 Thread Per Liden
Hi Jc, On 3/25/19 5:25 PM, Jean Christophe Beyler wrote: Hi Per, It looks good to me (not an official reviewer), my nit would be perhaps to add a print when you skip a configuration just for future debugging/understanding the log, perhaps?. Thanks for reviewing. I will add a println when we

Re: RFR: 8221396: Clean up serviceability/sa/TestUniverse.java

2019-03-25 Thread Per Liden
Thanks Stefan! /Per On 3/25/19 2:44 PM, Stefan Karlsson wrote: Looks good. StefanK On 2019-03-25 10:59, Per Liden wrote: Clean up serviceability/sa/TestUniverse.java to remove the need for the withZ/withoutZ option we currently pass in. This also changes the test to only run with the select

Re: RFR: 8221396: Clean up serviceability/sa/TestUniverse.java

2019-03-25 Thread Stefan Karlsson
Looks good. StefanK On 2019-03-25 10:59, Per Liden wrote: Clean up serviceability/sa/TestUniverse.java to remove the need for the withZ/withoutZ option we currently pass in. This also changes the test to only run with the selected GC instead of testing all GCs every time, which should save us

RFR: 8221396: Clean up serviceability/sa/TestUniverse.java

2019-03-25 Thread Per Liden
Clean up serviceability/sa/TestUniverse.java to remove the need for the withZ/withoutZ option we currently pass in. This also changes the test to only run with the selected GC instead of testing all GCs every time, which should save us some cycles in testing. Bug: https://bugs.openjdk.java.net