Hi Leonid,
I run the test with -XComp at Mach5 linux-x64-debug builds before and after the
changes the forwards VM and test options to j-* tools
and here is the difference in the execution times for some serviceability/sa
tests:
serviceability/sa/sadebugd/SADebugDTest.java, before : 2m 23s ,
Hi Daniil
Have you checked how longer tests are executed with adding java options
to launchers (with Xcomp/Graal/ZGC)?
If the overhead is not significant might be it make worth to add options
by default? The idea is to add vm.opts to all processes and java.opts to
tested only. But if you
On 4/23/20 10:18 AM, Daniil Titov wrote:
Hi Chris,
I will revoke this RFR and resubmit it under JDK-8242009
with the changes you suggested to use Utils.getTestJavaOpts()
and make JDKToolLauncher to have an option to forward VM options.
It could also be done with a new API such as
Correction...
The option name is -showversion, not "-Xshowversion"
Best regards,
Daniil
On 4/23/20, 10:18 AM, "Daniil Titov" wrote:
Hi Chris,
I will revoke this RFR and resubmit it under JDK-8242009
with the changes you suggested to use Utils.getTestJavaOpts()
and make
Hi Chris,
I will revoke this RFR and resubmit it under JDK-8242009
with the changes you suggested to use Utils.getTestJavaOpts()
and make JDKToolLauncher to have an option to forward VM options.
> Is your change causing -Xshowversion to be passed?
Yes, the changes makes tests run with
Hi Daniil,
Thanks for cleaning this up. I think this should be fixed under
JDK-8242009. JDK-8238561 involves more than just this one issue.
Is there a reason why you didn't just change JDKToolLauncher to have an
option or API to add the args?
Why are you calling Utils.addTestJavaOpts()
Please review the change [1] that ensures that VM and test options are
forwarded to
j*-tools when they are launched from serviceability/sa tests.
In particular, it will ensure that passed to the tests maximum heap size
settings ( -XX:MaxRAMPercentage)
are also honored by j*-tools
