On Wed, 28 Oct 2020 11:31:01 GMT, Lin Zang wrote:
>> - Parallel heap iteration support for PSS
>> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix constant coding styl
On Wed, 28 Oct 2020 11:00:32 GMT, Stefan Johansson wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refine HeapBlockClaimer implementation
>
> Thanks for the update, some additional comments, but just minor things.
>
>
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix constant coding style and do code refine
-
Changes:
- all: https://
On Mon, 26 Oct 2020 07:40:50 GMT, Lin Zang wrote:
>> - Parallel heap iteration support for PSS
>> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refine HeapBlockClaimer
On Thu, 22 Oct 2020 08:54:58 GMT, Stefan Johansson wrote:
>> Lin Zang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> Took a second look today and found two
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Refine HeapBlockClaimer implementation
-
Changes:
- all: https://git.op
On Thu, 22 Oct 2020 08:30:09 GMT, Stefan Johansson wrote:
>> Lin Zang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/hotspot/share/gc/parallel/psOldGen
On Mon, 26 Oct 2020 03:09:57 GMT, Lin Zang wrote:
>> src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp line 318:
>>
>>> 316: static const uint eden_index = 0;
>>> 317: static const uint survivor_index = 1;
>>> 318: static const uint num_inseparable_spaces = 2;
>>
>> One more comment.
On Wed, 21 Oct 2020 20:56:01 GMT, Stefan Johansson wrote:
>> Lin Zang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/hotspot/share/gc/parallel/parallel
On Mon, 19 Oct 2020 13:09:34 GMT, Lin Zang wrote:
>> - Parallel heap iteration support for PSS
>> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show diffe
On Wed, 21 Oct 2020 19:49:03 GMT, Stefan Johansson wrote:
>> Lin Zang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/hotspot/share/gc/parallel/parallel
On Mon, 19 Oct 2020 13:09:34 GMT, Lin Zang wrote:
>> - Parallel heap iteration support for PSS
>> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show diffe
On Mon, 19 Oct 2020 13:09:34 GMT, Lin Zang wrote:
>> - Parallel heap iteration support for PSS
>> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show diffe
On Tue, 20 Oct 2020 08:30:24 GMT, Stefan Johansson wrote:
> For future reference, you should avoid force pushing changes to open PRs.
> Instead of rebasing you can merge with master
> to make your branch up to date. This time it don't really matter since we
> didn't have any comments in the cod
On Tue, 20 Oct 2020 07:44:54 GMT, Lin Zang wrote:
>>> Dear @stefank,
>>> I have update this PR that use a claimer to help worker thread do parallel
>>> iteration. would you like to help review
>>> again? Thanks,
>>> Lin
>>
>> Wrong Stefan, I think you mean @kstefanj
>
> Hi @stefank,
> So s
On Tue, 20 Oct 2020 07:40:28 GMT, Stefan Karlsson wrote:
>> Dear @stefank,
>> I have update this PR that use a claimer to help worker thread do parallel
>> iteration. would you like to help review
>> again? Thanks,
>> Lin
>
>> Dear @stefank,
>> I have update this PR that use a claimer to help wo
On Mon, 19 Oct 2020 12:21:27 GMT, Lin Zang wrote:
> Dear @stefank,
> I have update this PR that use a claimer to help worker thread do parallel
> iteration. would you like to help review
> again? Thanks,
> Lin
Wrong Stefan, I think you mean @kstefanj
-
PR: https://git.openjdk.java
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull
gt;> From: "Hohensee, Paul"
>> To: Lin Zang ,
>>"hotspot-gc-...@openjdk.java.net"
>> ,
>>"serviceability-dev@openjdk.java.net"
>>
>> Subject: RE: RFR: 8252103: Parallel heap inspectio
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views
will show differences compared to the previous content of the PR. The pull
aul"
> To: Lin Zang ,
>"hotspot-gc-...@openjdk.java.net"
> ,
>"serviceability-dev@openjdk.java.net"
>
> Subject: RE: RFR: 8252103: Parallel heap inspection for
> ParallelScavengeHeap
On Fri, 9 Oct 2020 11:10:14 GMT, Stefan Johansson wrote:
>> Dear All,
>> May I ask your help to review this PR? Thanks!
>> -Lin
>
> Hi Lin,
>
> Sorry for not getting to this sooner. One of the reasons is that I haven't
> had time to explore a better solution, but
> the above notification trig
On Fri, 11 Sep 2020 07:25:37 GMT, Lin Zang wrote:
>> - Parallel heap iteration support for PSS
>> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
>
> Dear All,
> May I ask your help to review this PR? Thanks!
> -Lin
Hi Lin,
Sorry for not getting to this sooner. One of the reasons is
I'm not a GC specialist, but your approach looks reasonable to me.
parallelScavengeHeap.cpp:
"less that 1 workers" -> "less that 1 worker"
psOldGen.cpp:
">=2" -> ">= 2"
"thread_num-2 worker" -> "(thread_num -2) workers"
"cross blocks" -> "crosses blocks"
"that the object start address locate
On Sun, 6 Sep 2020 01:13:48 GMT, Lin Zang wrote:
> - Parallel heap iteration support for PSS
> - JBS: https://bugs.openjdk.java.net/browse/JDK-8252103
Dear All,
May I ask your help to review this PR? Thanks!
-Lin
-
PR: https://git.openjdk.java.net/jdk/pull/25
26 matches
Mail list logo
