Re: RFR: 8252406: Introduce Thread::as_Java_thread() convenience function [v8]

2020-09-10 Thread Daniel D . Daugherty
On Thu, 10 Sep 2020 03:18:23 GMT, David Holmes wrote: >> This is a rather large but generally simple cleanup. >> >> We use a lot of raw C-style casts to "(JavaThread*)" typically after >> checking "thread->is_Java_thread()". To simplify >> this pattern, and make the code look somewhat cleaner w

Re: RFR: 8252406: Introduce Thread::as_Java_thread() convenience function [v8]

2020-09-09 Thread Kim Barrett
On Thu, 10 Sep 2020 03:18:23 GMT, David Holmes wrote: >> This is a rather large but generally simple cleanup. >> >> We use a lot of raw C-style casts to "(JavaThread*)" typically after >> checking "thread->is_Java_thread()". To simplify >> this pattern, and make the code look somewhat cleaner w

Re: RFR: 8252406: Introduce Thread::as_Java_thread() convenience function [v8]

2020-09-09 Thread David Holmes
> This is a rather large but generally simple cleanup. > > We use a lot of raw C-style casts to "(JavaThread*)" typically after checking > "thread->is_Java_thread()". To simplify > this pattern, and make the code look somewhat cleaner we introduce a > convenience function Thread::as_Java_thread(