Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-16 Thread Richard Reingruber
On Wed, 16 Sep 2020 06:26:51 GMT, Chris Plummer wrote: >> Continuing review [1] after transition to Git/Github. >> >> I still cannot reproduce the issue. >> >> RFC on alternatives: >> >> 1. Integrate this change and ignore future JVMTI_ERROR_INVALID_SLOT >> 2. Don't ignore

Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-16 Thread Chris Plummer
On Sat, 12 Sep 2020 23:19:46 GMT, Richard Reingruber wrote: > Continuing review [1] after transition to Git/Github. > > I still cannot reproduce the issue. > > RFC on alternatives: > > 1. Integrate this change and ignore future JVMTI_ERROR_INVALID_SLOT > 2. Don't ignore

Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-15 Thread Serguei Spitsyn
On Sat, 12 Sep 2020 23:19:46 GMT, Richard Reingruber wrote: > Continuing review [1] after transition to Git/Github. > > I still cannot reproduce the issue. > > RFC on alternatives: > > 1. Integrate this change and ignore future JVMTI_ERROR_INVALID_SLOT > 2. Don't ignore

Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-15 Thread Richard Reingruber
On Tue, 15 Sep 2020 13:34:21 GMT, Richard Reingruber wrote: > I would like to take a different approach now for fixing this by making sure > the JVMTI GetLocalObject() call refers to > one of the recursiveMethod frames on stack. After a closer look I don't think this is possible. The

Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-15 Thread Richard Reingruber
On Tue, 15 Sep 2020 14:15:31 GMT, Daniel D. Daugherty wrote: >> Thanks @iignatev for providing the hint that helped finding the cause for >> the JVMTI_ERROR_INVALID_SLOT >> >>

Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-15 Thread Daniel D . Daugherty
On Tue, 15 Sep 2020 13:34:21 GMT, Richard Reingruber wrote: >> Continuing review [1] after transition to Git/Github. >> >> I still cannot reproduce the issue. >> >> RFC on alternatives: >> >> 1. Integrate this change and ignore future JVMTI_ERROR_INVALID_SLOT >> 2. Don't ignore

Re: RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-15 Thread Richard Reingruber
On Sat, 12 Sep 2020 23:19:46 GMT, Richard Reingruber wrote: > Continuing review [1] after transition to Git/Github. > > I still cannot reproduce the issue. > > RFC on alternatives: > > 1. Integrate this change and ignore future JVMTI_ERROR_INVALID_SLOT > 2. Don't ignore

RFR: 8252593: [TESTBUG] serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed with JVMTI_ERROR_INVALID_SLOT

2020-09-12 Thread Richard Reingruber
Continuing review [1] after transition to Git/Github. I still cannot reproduce the issue. RFC on alternatives: 1. Integrate this change and ignore future JVMTI_ERROR_INVALID_SLOT 2. Don't ignore JVMTI_ERROR_INVALID_SLOT but integrate the rest of this patch. If the test still fails with