Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]

2020-11-02 Thread Yasumasa Suenaga
On Tue, 27 Oct 2020 04:21:33 GMT, Nick Gasson wrote: >> When using the Linux "perf" tool to do system profiling, symbol names of >> running Java methods cannot be decoded, resulting in unhelpful output >> such as: >> >> 10.52% [JIT] tid 236748 [.] 0x7f6fdb75d223 >> >> Perf can read a

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]

2020-11-01 Thread Nick Gasson
On Fri, 30 Oct 2020 04:34:19 GMT, Yasumasa Suenaga wrote: > > Sure, the change looks good to me. However I don't understand why CSR is not > needed. It introduces new dcmd for Linux. I think because interfaces that are for diagnostic purposes don't require a CSR. See question 4 on the CSR

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]

2020-10-29 Thread Yasumasa Suenaga
On Wed, 21 Oct 2020 04:35:14 GMT, Yasumasa Suenaga wrote: >> Nick Gasson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make DumpPerfMapAtExit a diagnostic option > > Changes requested by ysuenaga (Reviewer). > @YaSuenag could you

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]

2020-10-29 Thread Nick Gasson
On Wed, 21 Oct 2020 04:35:14 GMT, Yasumasa Suenaga wrote: >> Nick Gasson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make DumpPerfMapAtExit a diagnostic option > > Changes requested by ysuenaga (Reviewer). @YaSuenag could you

Re: RFR: 8254723: add diagnostic command to write Linux perf map file [v5]

2020-10-26 Thread Nick Gasson
> When using the Linux "perf" tool to do system profiling, symbol names of > running Java methods cannot be decoded, resulting in unhelpful output > such as: > > 10.52% [JIT] tid 236748 [.] 0x7f6fdb75d223 > > Perf can read a simple text file format describing the mapping between > address