Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v4]

2020-11-11 Thread Lin Zang
On Wed, 11 Nov 2020 15:10:54 GMT, Igor Ignatyev wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add test id > > Hi @linzang , > > it all looks good to me, I'd, however, keep `@build` tags as they were > before, this

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v5]

2020-11-11 Thread Lin Zang
> The implementation of jmap tool depends on the implementation of object > iteration by different GC heap. > This patch extend the BasicJMapTest to cover differet GC Heap. Lin Zang has updated the pull request incrementally with one additional commit since the last revision: recover build

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v5]

2020-11-11 Thread Igor Ignatyev
On Wed, 11 Nov 2020 15:42:36 GMT, Lin Zang wrote: >> The implementation of jmap tool depends on the implementation of object >> iteration by different GC heap. >> This patch extend the BasicJMapTest to cover differet GC Heap. > > Lin Zang has updated the pull request incrementally with one

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v4]

2020-11-11 Thread Igor Ignatyev
On Wed, 11 Nov 2020 11:24:08 GMT, Lin Zang wrote: >> The implementation of jmap tool depends on the implementation of object >> iteration by different GC heap. >> This patch extend the BasicJMapTest to cover differet GC Heap. > > Lin Zang has updated the pull request incrementally with one

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v3]

2020-11-11 Thread Lin Zang
On Wed, 11 Nov 2020 11:13:29 GMT, Aleksey Shipilev wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refine the test configuration. > > I think it is fine to omit Epsilon from this testing. There is another trick > you

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v4]

2020-11-11 Thread Lin Zang
> The implementation of jmap tool depends on the implementation of object > iteration by different GC heap. > This patch extend the BasicJMapTest to cover differet GC Heap. Lin Zang has updated the pull request incrementally with one additional commit since the last revision: Add test id

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v3]

2020-11-11 Thread Aleksey Shipilev
On Wed, 11 Nov 2020 10:48:12 GMT, Lin Zang wrote: >> The implementation of jmap tool depends on the implementation of object >> iteration by different GC heap. >> This patch extend the BasicJMapTest to cover differet GC Heap. > > Lin Zang has updated the pull request incrementally with one

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v3]

2020-11-11 Thread Lin Zang
On Tue, 10 Nov 2020 17:50:26 GMT, Aleksey Shipilev wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refine the test configuration. > > I believe this would fail when some GCs are not available. For example, in >

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v3]

2020-11-11 Thread Lin Zang
> The implementation of jmap tool depends on the implementation of object > iteration by different GC heap. > This patch extend the BasicJMapTest to cover differet GC Heap. Lin Zang has updated the pull request incrementally with one additional commit since the last revision: Refine the test

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap [v2]

2020-11-11 Thread Lin Zang
> The implementation of jmap tool depends on the implementation of object > iteration by different GC heap. > This patch extend the BasicJMapTest to cover differet GC Heap. Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes

Re: RFR: 8255982: Extend BasicJMapTest to test with different GC Heap

2020-11-10 Thread Aleksey Shipilev
On Fri, 6 Nov 2020 12:54:28 GMT, Lin Zang wrote: > The implementation of jmap tool depends on the implementation of object > iteration by different GC heap. > This patch extend the BasicJMapTest to cover differet GC Heap. I believe this would fail when some GCs are not available. For example,

RFR: 8255982: Extend BasicJMapTest to test with different GC Heap

2020-11-06 Thread Lin Zang
The implementation of jmap tool depends on the implementation of object iteration by different GC heap. This patch extend the BasicJMapTest to cover differet GC Heap. - Commit messages: - 8255982: Extend BasicJMapTest to test with different GC Heap Changes: