Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump [v2]

2020-12-06 Thread Lin Zang
On Sat, 5 Dec 2020 19:12:37 GMT, Paul Hohensee wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove deadcode of println instead of change in HeapHprofBinWriter > > Marked as reviewed by phh (Reviewer). Dear all, Th

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump [v2]

2020-12-05 Thread Paul Hohensee
On Sat, 5 Dec 2020 00:35:27 GMT, Lin Zang wrote: >> when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump >> heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". >> Skip non-java thread stack dump to avoid printing the message. > > Lin Zang has updated

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump [v2]

2020-12-04 Thread Chris Plummer
On Sat, 5 Dec 2020 00:35:27 GMT, Lin Zang wrote: >> when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump >> heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". >> Skip non-java thread stack dump to avoid printing the message. > > Lin Zang has updated

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump [v2]

2020-12-04 Thread Lin Zang
On Fri, 4 Dec 2020 19:39:58 GMT, Chris Plummer wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove deadcode of println instead of change in HeapHprofBinWriter > > Marked as reviewed by cjplummer (Reviewer). @plumme

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump [v2]

2020-12-04 Thread Lin Zang
> when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump > heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". > Skip non-java thread stack dump to avoid printing the message. Lin Zang has updated the pull request incrementally with one additional commi

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump

2020-12-04 Thread Paul Hohensee
On Thu, 3 Dec 2020 12:06:23 GMT, Lin Zang wrote: > when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump > heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". > Skip non-java thread stack dump to avoid printing the message. Marked as reviewed by phh

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump

2020-12-04 Thread Serguei Spitsyn
On Thu, 3 Dec 2020 12:06:23 GMT, Lin Zang wrote: > when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump > heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". > Skip non-java thread stack dump to avoid printing the message. Hi Lin, It looks good. Tha

Re: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump

2020-12-04 Thread Chris Plummer
On Thu, 3 Dec 2020 12:06:23 GMT, Lin Zang wrote: > when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump > heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". > Skip non-java thread stack dump to avoid printing the message. Marked as reviewed by cjpl

RE: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump

2020-12-04 Thread Hohensee, Paul
ber 3, 2020 at 4:16 AM To: "serviceability-dev@openjdk.java.net" Subject: RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump heap" with "jhsdb clhsdb", it keep pri

RFR: 8257668: SA JMap - skip non-java thread stack dump for heap dump

2020-12-03 Thread Lin Zang
when use SA JMap dump commands, such as "jhsdb jmap --binaryheap" or "dump heap" with "jhsdb clhsdb", it keep printing "dumpStack: not java Thread.". Skip non-java thread stack dump to avoid printing the message. - Commit messages: - 8257668: SA JMap - skip non-java thread stack du