On Tue, 1 Jun 2021 04:23:43 GMT, Leonid Mesnik wrote:
> Thank you for your prompt response. I meant that it makes sense to update
> comments for RegisterMap to mention this. Currently, the doc says how to use
> it and how to disable update:
>
> "Updating of the RegisterMap can be turned off by
On Tue, 1 Jun 2021 04:09:13 GMT, Erik Österlund wrote:
>> Let me check with Erik if it makes sense to put more generic comments about
>> the usage of stackwatermark frame processing in RegisterMap, frames etc.
>> They can't be updated in an arbitrary thread state. It makes sense describe
>> t
On Tue, 1 Jun 2021 03:00:23 GMT, Leonid Mesnik wrote:
> Let me check with Erik if it makes sense to put more generic comments about
> the usage of stackwatermark frame processing in RegisterMap, frames etc.
> They can't be updated in an arbitrary thread state. It makes sense describe
> this i
On Thu, 27 May 2021 23:07:02 GMT, David Holmes wrote:
>> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
>
> src/hotspot/share/prims/forte.cpp line 326:
>
>> 324: int loop_count;
>> 325: int loop_max = MaxJavaStackTraceDepth * 2;
>> 326: RegisterMap map(thread, fals
On Thu, 27 May 2021 04:01:17 GMT, Leonid Mesnik wrote:
> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
I verified that async-profiles works with ZGC and data look reasonable.
-
PR: https://git.openjdk.java.net/jdk/pull/4217
On Thu, 27 May 2021 04:01:17 GMT, Leonid Mesnik wrote:
> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
Looks good, but please test with ZGC before integrating.
-
Marked as reviewed by eosterlund (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4217
On Thu, 27 May 2021 04:01:17 GMT, Leonid Mesnik wrote:
> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
Looks good. Could you verify the fix with ZGC? G1 doesn't use it, so testing
with G1 will only show that we don't hit the failing assert anymore.
-
Marked as
On Thu, 27 May 2021 04:01:17 GMT, Leonid Mesnik wrote:
> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
Hi Leonid,
Someone familiar with Stackwatermarks will need to comment about the validity
of doing this, my only comment is to document why it is being turned off.
Thanks,
On Thu, 27 May 2021 04:01:17 GMT, Leonid Mesnik wrote:
> 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
I verified that running sunflow with async-profiler crashed VM before the fix
and finished successfully after the fix. I compared data for G1GC for older JDK
before https:
8265148: StackWatermarkSet being updated during AsyncGetCallTrace
-
Commit messages:
- space removed.
- 8265148: StackWatermarkSet being updated during AsyncGetCallTrace
Changes: https://git.openjdk.java.net/jdk/pull/4217/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr
10 matches
Mail list logo
