Re: RFR: 8268857: Merge three vm operations in thread_dump [v3]

2021-06-17 Thread David Holmes
On 18/06/2021 12:29 pm, Denghui Dong wrote: On Thu, 17 Jun 2021 23:12:04 GMT, David Holmes wrote: Sorry still not a fan even with the hacked in deadline support for find_deadlocks. It is too arbitrary - you have no idea what constitutes a reasonable deadline, nor by how much you may overshoo

Re: RFR: 8268857: Merge three vm operations in thread_dump [v3]

2021-06-17 Thread Denghui Dong
On Thu, 17 Jun 2021 23:12:04 GMT, David Holmes wrote: > Sorry still not a fan even with the hacked in deadline support for > find_deadlocks. It is too arbitrary - you have no idea what constitutes a > reasonable deadline, nor by how much you may overshoot that deadline. > > David Hi David, T

Re: RFR: 8268857: Merge three vm operations in thread_dump [v3]

2021-06-17 Thread David Holmes
On Thu, 17 Jun 2021 15:32:01 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this change that merges three vm >> operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump >> and signal_thread_entry. >> >> `jstack` is a very common command, even in the production

Re: RFR: 8268857: Merge three vm operations in thread_dump [v3]

2021-06-17 Thread Denghui Dong
> Hi, > > Could I have a review of this change that merges three vm > operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and > signal_thread_entry. > > `jstack` is a very common command, even in the production environment. > > In addition to reduce the cost of entering s

Re: RFR: 8268857: Merge three vm operations in thread_dump [v2]

2021-06-16 Thread David Holmes
On Thu, 17 Jun 2021 05:15:36 GMT, Denghui Dong wrote: >> Hi, >> >> Could I have a review of this change that merges three vm >> operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump >> and signal_thread_entry. >> >> `jstack` is a very common command, even in the production

Re: RFR: 8268857: Merge three vm operations in thread_dump [v2]

2021-06-16 Thread Denghui Dong
> Hi, > > Could I have a review of this change that merges three vm > operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and > signal_thread_entry. > > `jstack` is a very common command, even in the production environment. > > In addition to reduce the cost of entering s

Re: RFR: 8268857: Merge three vm operations in thread_dump

2021-06-16 Thread Thomas Stuefe
On Wed, 16 Jun 2021 03:33:14 GMT, Denghui Dong wrote: > Hi, > > Could I have a review of this change that merges three vm > operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and > signal_thread_entry. > > `jstack` is a very common command, even in the production enviro

Re: RFR: 8268857: Merge three vm operations in thread_dump

2021-06-16 Thread Denghui Dong
On Wed, 16 Jun 2021 04:08:10 GMT, David Holmes wrote: > Sorry but I do not agree with this change. I understand your rationale but > you have overlooked that by combining these three safepoint operations you > have created a much longer safepoint pause which may lock out other more > important

Re: RFR: 8268857: Merge three vm operations in thread_dump

2021-06-15 Thread David Holmes
On Wed, 16 Jun 2021 03:33:14 GMT, Denghui Dong wrote: > Hi, > > Could I have a review of this change that merges three vm > operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and > signal_thread_entry. > > `jstack` is a very common command, even in the production enviro

RFR: 8268857: Merge three vm operations in thread_dump

2021-06-15 Thread Denghui Dong
Hi, Could I have a review of this change that merges three vm operations(VM_PrintThreads, VM_PrintJNI, VM_FindDeadlocks) in thread_dump and signal_thread_entry. `jstack` is a very common command, even in the production environment. In addition to reduce the cost of entering safepoint, I think