Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-05 Thread Serguei Spitsyn
On Mon, 4 Oct 2021 13:02:37 GMT, Yasumasa Suenaga wrote: >> Use >> [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) >> to check the version of debugee. >> >> Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has

Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-04 Thread Chris Plummer
On Mon, 4 Oct 2021 13:02:37 GMT, Yasumasa Suenaga wrote: >> Use >> [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) >> to check the version of debugee. >> >> Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has

Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-04 Thread Yasumasa Suenaga
> Use > [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) > to check the version of debugee. > > Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has following > code to check the version of debugee. > > >

Re: RFR: 8274670: Improve version string handling in SA [v2]

2021-10-04 Thread Yasumasa Suenaga
On Mon, 4 Oct 2021 12:07:02 GMT, Andrey Turbanov wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove toString() calls > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchExcepti

Re: RFR: 8274670: Improve version string handling in SA

2021-10-04 Thread Andrey Turbanov
On Sun, 3 Oct 2021 13:08:58 GMT, Yasumasa Suenaga wrote: > Use > [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) > to check the version of debugee. > > Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has foll

RFR: 8274670: Improve version string handling in SA

2021-10-03 Thread Yasumasa Suenaga
Use [java.lang.Runtime.Version](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Runtime.Version.html) to check the version of debugee. Currently `checkVMVersion()` in `sun.jvm.hotspot.runtime.VM` has following code to check the version of debugee. if (saVersion.