Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-03 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 23:17:30 GMT, Vladimir Kozlov wrote: >> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be >> qualified. >> Testing: >> - `make test TEST="gtest"`: Passed >> - `make run-test TEST="tier1"`: Passed >> - `make run-test TEST="tier2"`: Passed >> - `make

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Tue, 2 Nov 2021 23:03:22 GMT, Evgeny Astigeevich wrote: > Is NULL method holder an acceptable situation? Could it be a sign of a bug? You are right, all methods should have class holders. I just followed code pattern. > BTW, `Klass::external_name()` returns `` if `Klass::name()` is > `NUL

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 22:57:23 GMT, Vladimir Kozlov wrote: > Yes, I am currently testing similar fix: > > ``` > -Klass* klass = method->method_holder(); > -assert(klass->is_loader_alive(), "must be alive"); > +Klass* methHolder = method->method_holder(); > +

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 22:05:01 GMT, Vladimir Kozlov wrote: > I don't think we need this assert just to print klass's name. May be follow > the code pattern for method's name and signature. Agree. I'll submit PR with the code: Symbol* className = klass->name(); const char* classNameS = (classNam

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Vladimir Kozlov
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Lutz Schmidt
On Tue, 2 Nov 2021 17:03:50 GMT, Evgeny Astigeevich wrote: >> src/hotspot/share/code/codeHeapState.cpp line 2340: >> >>> 2338: >>> 2339: Klass* klass = method->method_holder(); >>> 2340: assert(klass->is_loader_alive(), "must be alive"); >> >> Are you sure `klass` is a

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Lutz Schmidt
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 05:49:30 GMT, Yi Yang wrote: >> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be >> qualified. >> Testing: >> - `make test TEST="gtest"`: Passed >> - `make run-test TEST="tier1"`: Passed >> - `make run-test TEST="tier2"`: Passed >> - `make run-test

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Evgeny Astigeevich
On Tue, 2 Nov 2021 16:34:34 GMT, Volker Simonis wrote: >> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be >> qualified. >> Testing: >> - `make test TEST="gtest"`: Passed >> - `make run-test TEST="tier1"`: Passed >> - `make run-test TEST="tier2"`: Passed >> - `make r

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Paul Hohensee
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Volker Simonis
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Volker Simonis
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Tobias Hartmann
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-01 Thread Yi Yang
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-01 Thread Evgeny Astigeevich
This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be qualified. Testing: - `make test TEST="gtest"`: Passed - `make run-test TEST="tier1"`: Passed - `make run-test TEST="tier2"`: Passed - `make run-test TEST=`: serviceability/dcmd/compiler/CodeHeapAnalyticsMethodNames.jav