Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-19 Thread David Holmes
Thanks Nils. Looks good to me too. David On 19/02/2013 10:52 PM, Nils Loodin wrote: Here's the updated webrev: http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ Regards, Nils Loodin On 02/19/2013 12:09 PM, Nils Loodin wrote: On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:4

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-19 Thread Staffan Larsen
Looks good. /Staffan On 19 feb 2013, at 13:52, Nils Loodin wrote: > Here's the updated webrev: > > http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ > > Regards, > Nils Loodin > > On 02/19/2013 12:09 PM, Nils Loodin wrote: >> On 02/09/2013 03:13 AM, David Holmes wrote: >>> On 9/02/2013

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-19 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 2/19/13 4:52 AM, Nils Loodin wrote: Here's the updated webrev: http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ Regards, Nils Loodin On 02/19/2013 12:09 PM, Nils Loodin wrote: On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:40 AM, Nils Loodin

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-19 Thread Nils Loodin
Here's the updated webrev: http://cr.openjdk.java.net/~nloodin/8007804/webrev.01/ Regards, Nils Loodin On 02/19/2013 12:09 PM, Nils Loodin wrote: On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:40 AM, Nils Loodin wrote: Please review the following very small and insignificant chan

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-19 Thread Nils Loodin
On 02/09/2013 03:13 AM, David Holmes wrote: On 9/02/2013 2:40 AM, Nils Loodin wrote: Please review the following very small and insignificant change: Basically, I need to access a performance-counter by name from within the JVM. The method name by_name seems a little odd to me. find_by_name wo

Re: RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-08 Thread David Holmes
On 9/02/2013 2:40 AM, Nils Loodin wrote: Please review the following very small and insignificant change: Basically, I need to access a performance-counter by name from within the JVM. The method name by_name seems a little odd to me. find_by_name would seem more consistent (particularly if yo

RFR: JDK-8007804: Need to be able to access Performance counter by name from JVM

2013-02-08 Thread Nils Loodin
Please review the following very small and insignificant change: Basically, I need to access a performance-counter by name from within the JVM. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007804 http://cr.openjdk.java.net/~nloodin/8007804/webrev.00/ Regards, Nils Loodin