Re: RFR: JDK-8201513: nsk/jvmti/IterateThroughHeap/filter-* are broken

2018-07-12 Thread Chris Plummer
+1 On 7/11/18 2:26 PM, serguei.spit...@oracle.com wrote: Hi Alex, The fix looks good. Thank you for fixing the typos! Thanks, Serguei On 7/11/18 11:39, Alex Menkov wrote: Hi all, please review a fix for https://bugs.openjdk.java.net/browse/JDK-8201513 webrev: http://cr.openjdk.java.net/~am

Re: RFR: JDK-8201513: nsk/jvmti/IterateThroughHeap/filter-* are broken

2018-07-11 Thread serguei.spit...@oracle.com
Hi Alex, The fix looks good. Thank you for fixing the typos! Thanks, Serguei On 7/11/18 11:39, Alex Menkov wrote: Hi all, please review a fix for https://bugs.openjdk.java.net/browse/JDK-8201513 webrev: http://cr.openjdk.java.net/~amenkov/IterateThroughHeap/webrev/ summary: The tests had a

RFR: JDK-8201513: nsk/jvmti/IterateThroughHeap/filter-* are broken

2018-07-11 Thread Alex Menkov
Hi all, please review a fix for https://bugs.openjdk.java.net/browse/JDK-8201513 webrev: http://cr.openjdk.java.net/~amenkov/IterateThroughHeap/webrev/ summary: The tests had a error which was fixed during open-sourcing. After that the tests started to fail. Root cause of the failures is wrong