Re: RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-24 Thread Chris Plummer
Hi Gary, I'm curious as to what event is triggering this. When the JVMTI event comes in, you eventually end up in this code in enqueueCommand():     if (wait) {     debugMonitorEnter(commandCompleteLock);     while (!command->done

Re: RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-24 Thread Chris Plummer
Hi Gary, On 5/24/19 5:17 AM, Gary Adams wrote: I have not tracked down the specific root cause of this failure, yet. It appears that the suspend is being attempted before the thread has been recorded in threadControl.

Re: RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-24 Thread Gary Adams
I have not tracked down the specific root cause of this failure, yet. It appears that the suspend is being attempted *before* the thread has been recorded in *threadControl*. Adding diagnostic messages is tricky because it changes the timing. Here's a minimal probe to track threadControl addNode

Re: RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-23 Thread Chris Plummer
Hi Gary, So a JVMTI event came in on a valid thread, got processed by the Debug Agent and enqueued to be sent to the Debugger. However, before it was actually sent, the thread became invalid. Am I understanding this issue correctly? thanks, Chris On 5/23/19 2:59 AM, gary.ad...@oracle.com w

RFR: JDK-8218701: jdb tests failed with AGENT_ERROR_INVALID_THREAD

2019-05-23 Thread gary.ad...@oracle.com
This proposed workaround ensures that the delay between a suspend request passing through the jdwp command queue will not fail due to a no longer running thread.   Webrev: http://cr.openjdk.java.net/~gadams/8218701/webrev/   Issue: https://bugs.openjdk.java.net/browse/JDK-8218701