On 25/10/2019 11:32 pm, Harold Seigel wrote:
The changes were pushed to the records branch of the amber repo:
http://hg.openjdk.java.net/amber/amber
Okay. I thought we were doing a code review ready for this to go into
mainline.
David
-
Harold
On 10/25/2019 9:23 AM, David Holmes wrote
Hi Harold,
The update looks good.
Thanks,
Serguei
On 10/24/19 10:50, Harold Seigel wrote:
Hi David,
Thanks for reviewing this!
Here's an updated webrev containing the below changes (and one change
requested by Serguei). Could you take a look?
http://cr.openjdk.java.net/~hseigel/records.r
Thanks Serguei!
Harold
On 10/25/2019 1:21 PM, serguei.spit...@oracle.com wrote:
Hi Harold,
The update looks good.
Thanks,
Serguei
On 10/24/19 10:50, Harold Seigel wrote:
Hi David,
Thanks for reviewing this!
Here's an updated webrev containing the below changes (and one change
requested b
The changes were pushed to the records branch of the amber repo:
http://hg.openjdk.java.net/amber/amber
Harold
On 10/25/2019 9:23 AM, David Holmes wrote:
On 25/10/2019 9:49 pm, Harold Seigel wrote:
Thanks David!
I should have mentioned that I had pushed Serguei's jvmti.xml and
TestRecordAtt
On 25/10/2019 9:49 pm, Harold Seigel wrote:
Thanks David!
I should have mentioned that I had pushed Serguei's jvmti.xml and
TestRecordAttr*.java changes earlier.
Pushed under what bug id to where? This JEP is still only a Candidate.
David
Harold
On 10/24/2019 8:40 PM, David Holmes wrote:
Thanks David!
I should have mentioned that I had pushed Serguei's jvmti.xml and
TestRecordAttr*.java changes earlier.
Harold
On 10/24/2019 8:40 PM, David Holmes wrote:
Hi Harold,
On 25/10/2019 3:50 am, Harold Seigel wrote:
Hi David,
Thanks for reviewing this!
Here's an updated webrev con
Hi Harold,
On 25/10/2019 3:50 am, Harold Seigel wrote:
Hi David,
Thanks for reviewing this!
Here's an updated webrev containing the below changes (and one change
requested by Serguei). Could you take a look?
http://cr.openjdk.java.net/~hseigel/records.review.rt.01/webrev/index.html
T
Hi David,
Thanks for reviewing this!
Here's an updated webrev containing the below changes (and one change
requested by Serguei). Could you take a look?
http://cr.openjdk.java.net/~hseigel/records.review.rt.01/webrev/index.html
Please also see in-line comments.
On 10/23/2019 7:16 PM, Da
Thanks Serguei!
I will make the changes that you suggest.
Harold
On 10/24/2019 2:01 AM, serguei.spit...@oracle.com wrote:
Hi Vicente and Harold,
The fix looks good to me.
Nice set of tests!
I have a couple of nits besides what other reviewers already commented.
http://cr.openjdk.java.net/~v
Hi Vicente and Harold,
The fix looks good to me.
Nice set of tests!
I have a couple of nits besides what other reviewers already
commented.
http://cr.openjdk.java.net/~vromero/records.review/hotspot_runtime/webrev.00/test/jdk/java/lang
Hi Vicente, (and Harold!)
On 19/10/2019 4:44 am, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
I've looked at all the code, though not in great detail i.e I have not
validated the code changes against the proposed specification. S
Hi Sergei,
Thanks for looking at the change.
I'll fix line 7789 in jvmti.xml before the change gets pushed.
Harold
On 10/23/2019 3:46 AM, serguei.spit...@oracle.com wrote:
Hi Vicente and Harold,
I'm still reviewing this, it looks pretty good so far.
One quick comment about a pre-existed iss
Thanks David,
Vicente
On 10/22/19 7:01 PM, David Holmes wrote:
Hi Vicente,
I plan to look at this ASAP.
Cheers,
David
On 19/10/2019 4:44 am, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vice
Hi Vicente and Harold,
I'm still reviewing this, it looks pretty good so far.
One quick comment about a pre-existed issue (not your fault).
The jvmti.xml has an update to add the Record attribute into the
list of attributes that must not be changed:
Hi Vicente,
I plan to look at this ASAP.
Cheers,
David
On 19/10/2019 4:44 am, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the development
[1]
http://cr.op
Hi Lois,
Thanks for the review,
Vicente
On 10/21/19 2:40 PM, Lois Foltan wrote:
On 10/18/2019 2:44 PM, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the devel
Thanks Lois!
Please see comments inline.
On 10/21/2019 2:40 PM, Lois Foltan wrote:
On 10/18/2019 2:44 PM, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the dev
On 10/18/2019 2:44 PM, Vicente Romero wrote:
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the development
[1]
http://cr.openjdk.java.net/~vromero/records.review/hotspot_runtime/web
Hi,
Please review the hotspot runtime and serviceability code for JEP 359
(Records).
Thanks in advance for the feedback,
Vicente
PS, Thanks to Harold for the development
[1]
http://cr.openjdk.java.net/~vromero/records.review/hotspot_runtime/webrev.00/
19 matches
Mail list logo
