Re: RFR (L): 8241214: Test debugging of hidden classes using jdb

2020-04-22 Thread serguei.spit...@oracle.com
Hi Leonid, Thank you for the review! I'll address your comments. Thanks, Serguei On 4/22/20 13:06, Leonid Mesnik wrote: Looks good, Here are several comments, mostly about code style/compliance. No a

Re: RFR (L): 8241214: Test debugging of hidden classes using jdb

2020-04-22 Thread Leonid Mesnik
Looks good, Here are several comments, mostly about code style/compliance. No another review is needed if you want to fix them. http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-hidden-jdb.7/test/hotspot/jtreg/vmTestbase/nsk/jdb/hidden_class/hc001/hc001.java.html 36 interface HC_Inte

RFR (L): 8241214: Test debugging of hidden classes using jdb

2020-04-22 Thread serguei.spit...@oracle.com
Please, review a fix for the sub-task:   https://bugs.openjdk.java.net/browse/JDK-8241214 This fix has already been reviewed internally (in Vlahalla project) by Mandy, Chris and Alex. This RFR is to collect more comments (if there are any) before