Re: RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-24 Thread serguei.spit...@oracle.com
Thank you a lot for review, Dan! It was also reviewed by Jon Gibbons and Kumar Srinivasan. So that, I can push it now. Thanks, Serguei On 8/24/17 13:25, Daniel D. Daugherty wrote: On 8/17/17 12:53 PM,

Re: RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-24 Thread Daniel D. Daugherty
On 8/17/17 12:53 PM, serguei.spit...@oracle.com wrote: Please, review a fix for the bug: https://bugs.openjdk.java.net/browse/JDK-8185687 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8185687-jvmti-spec.1/ src/share/vm/prims/jvmti.xml     No comments.

Re: RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-24 Thread serguei.spit...@oracle.com
An update. I've got a thumbs up from Kumar (thanks, Kumar!) and also asked Dan if he has a chance to look at it. Thanks, Serguei On 8/17/17 11:53, serguei.spit...@oracle.com wrote: Please, review a fix for

Re: RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-24 Thread serguei.spit...@oracle.com
Please, skip this email. It was for Dan only. I forgot to remove the serviceability-dev for the list. Thanks, Serguei On 8/24/17 10:39, serguei.spit...@oracle.com wrote: Dan, This is a minor fix

Re: RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-24 Thread serguei.spit...@oracle.com
Dan, This is a minor fix in the JVMTI spec. But as you see it has to deal with the XSLT scripts. One more review will be needed for this fix. Both reviews are not urgent but the 8051228 is more important. Thanks, Serguei

RFR (S) 8185687: Fix minor bugs in jvmti specification

2017-08-17 Thread serguei.spit...@oracle.com
Please, review a fix for the bug:   https://bugs.openjdk.java.net/browse/JDK-8185687 Webrev:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8185687-jvmti-spec.1/ Summary:   The DocCheck utility reports 4 errors in