Re: RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

2018-08-30 Thread Daniel D. Daugherty
Adding hotspot-runtime-dev@... to this thread... More below... On 8/28/18 3:37 PM, mandy chung wrote: On 8/24/18 7:06 AM, Daniel Fuchs wrote: Hi Harsha, On 23/08/2018 17:35, Daniel Fuchs wrote: So all in all - maybe this is worth fixing but better early in the release than late. I also

Re: RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

2018-08-28 Thread mandy chung
On 8/24/18 7:06 AM, Daniel Fuchs wrote: Hi Harsha, On 23/08/2018 17:35, Daniel Fuchs wrote: So all in all - maybe this is worth fixing but better early in the release than late. I also wonder whether such a behavior change should deserve a release note (or a switch to revert to the old

Re: RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

2018-08-24 Thread Sundararajan Athijegannathan
+1. It is better not to fix this bug. -Sundar On 24/08/18, 7:36 PM, Daniel Fuchs wrote: Hi Harsha, On 23/08/2018 17:35, Daniel Fuchs wrote: So all in all - maybe this is worth fixing but better early in the release than late. I also wonder whether such a behavior change should deserve a

Re: RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

2018-08-23 Thread Daniel Fuchs
Hi Harsha, On a high level point of view, I think the fix looks good. I like the use of CopyOnWriteArrayList and removeIf. IIUC there is a single instance of ServiceThread in the VM, so using a static single thread executor to call the listeners should preserve the order in which the

RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

2018-07-17 Thread Harsha Wardhana B
Hi All, Please review the fix for the bug, JDK-8170299 - Debugger does not stop inside the low memory notifications code webrev at, http://cr.openjdk.java.net/~hb/8170299/webrev.00/ Description of the fix: The debugger does not stop inside