Re: RFR 6791551: ExclusiveBind.java has a race condition

2014-02-10 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 10 feb 2014, at 13:00, Jaroslav Bachorik wrote: > On 4.2.2014 16:07, shanliang wrote: >> Jaroslav Bachorik wrote: >>> On 4.2.2014 09:54, shanliang wrote: Jaroslav, Your fix should work in most case, but is it better and more reliable to wait

Re: RFR 6791551: ExclusiveBind.java has a race condition

2014-02-10 Thread Jaroslav Bachorik
On 4.2.2014 16:07, shanliang wrote: Jaroslav Bachorik wrote: On 4.2.2014 09:54, shanliang wrote: Jaroslav, Your fix should work in most case, but is it better and more reliable to wait a VM event as suggested in the bug? even your timeout is adapted to the test time factory, but the solution s

Re: RFR 6791551: ExclusiveBind.java has a race condition

2014-02-04 Thread shanliang
Jaroslav Bachorik wrote: On 4.2.2014 09:54, shanliang wrote: Jaroslav, Your fix should work in most case, but is it better and more reliable to wait a VM event as suggested in the bug? even your timeout is adapted to the test time factory, but the solution still depends to a fixed timeout and a

Re: RFR 6791551: ExclusiveBind.java has a race condition

2014-02-04 Thread Jaroslav Bachorik
On 4.2.2014 09:54, shanliang wrote: Jaroslav, Your fix should work in most case, but is it better and more reliable to wait a VM event as suggested in the bug? even your timeout is adapted to the test time factory, but the solution still depends to a fixed timeout and a fixed line out. Well,

Re: RFR 6791551: ExclusiveBind.java has a race condition

2014-02-04 Thread shanliang
Jaroslav, Your fix should work in most case, but is it better and more reliable to wait a VM event as suggested in the bug? even your timeout is adapted to the test time factory, but the solution still depends to a fixed timeout and a fixed line out. Shanliang Jaroslav Bachorik wrote: Ple

RFR 6791551: ExclusiveBind.java has a race condition

2014-02-03 Thread Jaroslav Bachorik
Please, review the following test fix: Issue : https://bugs.openjdk.java.net/browse/JDK-6791551 Webrev: http://cr.openjdk.java.net/~jbachorik/6791551/webrev.00 The fix prevents the situation when the first debuggee has not managed to finish its intialization while the second one is started up t