Hi Severin,
On 10/9/18 8:50 AM, Severin Gehwolf wrote:
Hi Seguei,
On Mon, 2018-10-08 at 17:57 -0700, serguei.spit...@oracle.com wrote:
Hi Severin,
You already fixed a couple of deadlocks in the debugger method
invocation and have an expertise in this area.
Do you have any time to review the w
Hi Seguei,
On Mon, 2018-10-08 at 17:57 -0700, serguei.spit...@oracle.com wrote:
> Hi Severin,
>
> You already fixed a couple of deadlocks in the debugger method
> invocation and have an expertise in this area.
> Do you have any time to review the webrev from Daniil?
Sorry, not at the moment. It'
, 2018 at 5:53 PM
To: Daniil Titov , Chris Plummer
,
Cc: serviceability-dev
Subject: Re: RFR 8193879: Java debugger hangs on method invocation
Hi Daniil,
It seems to me, this fix is going to work.
The freeze() method only cares there are no pending resume commands:
99 synchronized
is Plummer
,
Cc: serviceability-dev
Subject: Re: RFR 8193879: Java debugger hangs on
method invocation
Hi Daniil,
It seems to me, this fix is goi
);
+ return (BreakpointEvent) waitForRequestedEvent(request);
Best regards,
Daniil
From: "serguei.spit...@oracle.com"
Date: Monday, October 8, 2018 at 5:53 PM
To: Daniil Titov , Chris Plummer
,
Cc: serviceability-dev
Subject: Re: RFR 8193879: Java debugger hangs on method invocat
Hi Severin,
You already fixed a couple of deadlocks in the debugger method
invocation and have an expertise in this area.
Do you have any time to review the webrev from Daniil?
Otherwise, I'd like to keep you aware about this fix.
Thanks,
Hi Daniil,
It seems to me, this fix is going to work.
The freeze() method only cares there are no pending resume
commands:
99 synchronized void freeze() {
100 if (cache == null && (pendingResumeCommands.isEmpty())) {
101 /
Looks OK to me.
On 10/4/18 5:19 PM, Daniil Titov wrote:
Hi Gary and Chris,
Please review an updated version of the patch that has newly added test for the
case when suspend policy is set to SUSPEND_EVENT_THREAD reimplemented using JDI
API. Thus, the changes in
src/jdk.jdi/share/classes/com/s
On 10/4/18 6:00 PM, Alex Menkov wrote:
On 10/04/2018 16:11, Chris Plummer wrote:
On 10/4/18 2:53 PM, Alex Menkov wrote:
On 10/04/2018 10:28, Chris Plummer wrote:
On 10/4/18 5:12 AM, Gary Adams wrote:
In TTY.java do you need to force a simple prompt for the
breakpoint event output? What pr
On 10/04/2018 16:11, Chris Plummer wrote:
On 10/4/18 2:53 PM, Alex Menkov wrote:
On 10/04/2018 10:28, Chris Plummer wrote:
On 10/4/18 5:12 AM, Gary Adams wrote:
In TTY.java do you need to force a simple prompt for the
breakpoint event output? What prevents currentThread from
being set at
On 10/4/18 2:53 PM, Alex Menkov wrote:
On 10/04/2018 10:28, Chris Plummer wrote:
On 10/4/18 5:12 AM, Gary Adams wrote:
In TTY.java do you need to force a simple prompt for the
breakpoint event output? What prevents currentThread from
being set at the time you are printing the prompt?
103
Looks good to me.
--alex
On 10/04/2018 15:13, Daniil Titov wrote:
Hi Alex,
Just several minutes ago in another email I sent an updated patch on review
(please see email attached). The patch has reimplemented tests and no longer
uses JdbTest , so the changes you mentioned are no longer there.
Hi Alex,
Just several minutes ago in another email I sent an updated patch on review
(please see email attached). The patch has reimplemented tests and no longer
uses JdbTest , so the changes you mentioned are no longer there. I also created
issue https://bugs.openjdk.java.net/browse/JDK-821173
On 10/04/2018 10:28, Chris Plummer wrote:
On 10/4/18 5:12 AM, Gary Adams wrote:
In TTY.java do you need to force a simple prompt for the
breakpoint event output? What prevents currentThread from
being set at the time you are printing the prompt?
103 // Print the prompt if suspend p
Hi Gary and Chris,
Please review an updated version of the patch that has newly added test for the
case when suspend policy is set to SUSPEND_EVENT_THREAD reimplemented using JDI
API. Thus, the changes in
src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTY.java are no
longer required
On 10/4/18 5:12 AM, Gary Adams wrote:
In TTY.java do you need to force a simple prompt for the
breakpoint event output? What prevents currentThread from
being set at the time you are printing the prompt?
103 // Print the prompt if suspend policy is
SUSPEND_EVENT_THREAD. In case of
10
In TTY.java do you need to force a simple prompt for the
breakpoint event output? What prevents currentThread from
being set at the time you are printing the prompt?
103 // Print the prompt if suspend policy is
SUSPEND_EVENT_THREAD. In case of
104 // SUSPEND_ALL policy this is
Please review the changes that fix the deadlock in the debugger when the
debugger is running with the tracing option on.
The problem here is that when the tracing is on the "JDI Target VM Interface"
thread (the thread that reads all replies and then notifies the thread that
sent the request th
18 matches
Mail list logo
