Thanks Serguei!
David
On 24/06/2018 3:55 PM, serguei.spit...@oracle.com wrote:
On 6/23/18 16:19, serguei.spit...@oracle.com wrote:
On 6/23/18 15:53, David Holmes wrote:
On 24/06/2018 7:58 AM, serguei.spit...@oracle.com wrote:
Hi David,
This was your suggestion:
There was only one part of
On 6/23/18 16:19, serguei.spit...@oracle.com wrote:
On 6/23/18 15:53, David Holmes wrote:
On 24/06/2018 7:58 AM, serguei.spit...@oracle.com wrote:
Hi David,
This was your suggestion:
There was only one part of the patch being debated! The rest of the
patch was still applicable. Jeremy spec
On 6/23/18 15:53, David Holmes wrote:
On 24/06/2018 7:58 AM, serguei.spit...@oracle.com wrote:
Hi David,
This was your suggestion:
There was only one part of the patch being debated! The rest of the
patch was still applicable. Jeremy specifically stated
"That would be okay with me, assumi
On 24/06/2018 7:58 AM, serguei.spit...@oracle.com wrote:
Hi David,
This was your suggestion:
There was only one part of the patch being debated! The rest of the
patch was still applicable. Jeremy specifically stated
"That would be okay with me, assuming that my other corrections are
made.
Hi David,
This was your suggestion:
---
Sent when a method causes the virtual machine to directly allocate an
Object visible to Java programming language code.
Generally object allocation can be detected by instrumenting
the bytecodes of allocating methods.
Object allocation generated
On 23/06/2018 6:25 PM, serguei.spit...@oracle.com wrote:
I've pushed the version suggested by David.
But you left out all of Jeremy's other fixups!
David
Thanks,
serguei
On 6/22/18 09:00, serguei.spit...@oracle.com wrote:
Hi Jeremy,
Okay, let me look at it once more before making final d
I've pushed the version suggested by
David.
Thanks,
serguei
On 6/22/18 09:00, serguei.spit...@oracle.com wrote:
Hi Jeremy,
Okay, let me look at it once more before making final decision.
We have
Hi Jeremy,
Okay, let me look at it once more before making final decision.
We have all suggestions and preferences listed.
Thanks,
Serguei
On 6/22/18 08:22, Jeremy Manson wrote:
Hey folks -
On 20/06/2018 4:48 PM, serguei.spit...@oracle.com wrote:
On 6/19/18 23:29, Jeremy Manson wrote:
Maybe we should make that clarification.
Also, the reason I danced around that in my revision is that
Understand that.
But it is not a good style to clarify about SampledObjectAlloc in the
spec of
On 6/19/18 23:29, Jeremy Manson wrote:
Maybe we should make that clarification.
Also, the reason I danced around that in my revision is
that
Understand that.
But it is not a good style to clarify about Sa
On 6/19/18 21:54, David Holmes wrote:
On 20/06/2018 2:41 PM, serguei.spit...@oracle.com wrote:
On 6/19/18 21:11, Jeremy Manson wrote:
That would be okay with me, assuming that my other corrections are
made.
Another option would be to say "non-sampling" instead of
"unconditional":
== Sent w
On 20/06/2018 2:41 PM, serguei.spit...@oracle.com wrote:
On 6/19/18 21:11, Jeremy Manson wrote:
That would be okay with me, assuming that my other corrections are made.
Another option would be to say "non-sampling" instead of "unconditional":
== Sent when a method causes the virtual machine t
On 6/19/18 21:11, Jeremy Manson wrote:
That would be okay with me, assuming that my other
corrections are made.
Another option would be to say "non-sampling" instead of
"unconditional":
== Sent when a method causes the vir
That would be okay with me, assuming that my other corrections are made.
I'd also like to fix the spelling of instrumentation in the first sentence.
Jeremy
On Mon, Jun 18, 2018 at 11:01 PM serguei.spit...@oracle.com <
serguei.spit...@oracle.com> wrote:
> Hi Jeremy and David,
>
> Sorry for being
Hi Jeremy and David,
Sorry for being late to the party.
I'm also concerned about the Jeremy's spec update is more
intrusive than necessary.
One specifics of the new SampledObjectAlloc event is that it is
posted conditionally.
So, it is no
On 19/06/2018 4:50 AM, Jeremy Manson wrote:
Yup! The paragraph meanders a bit. How about something like:
I'm not sure some of the change quite works. The original text considers
there to be three kinds of methods that can cause allocation when executed:
- Java (bytecode) methods
- JNI metho
Yup! The paragraph meanders a bit. How about something like:
Sent when the virtual machine allocates an
Object visible to Java programming language code without using a
new bytecode variant or a JNI method.
Many approaches to tracking object allocation use a combination of
bytecode-based instrum
On 18/06/2018 5:01 PM, Jeremy Manson wrote:
We haven't changed when a VM issues "VM object allocation" events.
There were references in the docs to a requirement to use bytecode
rewriting and JNI interception to track allocations. With
SampledObjectAlloc, this is no longer the case - SampledO
We haven't changed when a VM issues "VM object allocation" events.
There were references in the docs to a requirement to use bytecode
rewriting and JNI interception to track allocations. With
SampledObjectAlloc, this is no longer the case - SampledObjectAlloc can
track them. This change is suppo
Hi Jeremy,
On 16/06/2018 2:33 AM, Jeremy Manson wrote:
Hi all,
There are a number of references in the JVMTI doc to its not doing
object allocation tracking. Now that JEP 331 has landed, these
references are obsolete. This patch changes those references accordingly.
While I was there, I t
20 matches
Mail list logo
