Hi Roger,
It looks good to me.
Thanks,
Serguei
On 2/13/20 7:52 AM, Roger Riggs wrote:
Please review a minor cleanup to remove code long since unnecessary.
The type of the BadAttributeValueExpException argument is String and
if it is not a string in the serialized stream, a suitable
Hi Roger,
OK - I can accept that then.
best regards,
-- daniel
On 13/02/2020 18:18, Roger Riggs wrote:
Hi Daniel,
That's part of the technical debt that has to go.
The change to do the conversion in the constructor has been there since
JDK8.
And the value of the argument is informative.
Hi Daniel,
That's part of the technical debt that has to go.
The change to do the conversion in the constructor has been there since
JDK8.
And the value of the argument is informative.
There isn't too much overhead in keeping them but the are just noise at
this point.
Thanks, Roger
On
Hi Roger,
I think you will need to preserve these cases:
On 13/02/2020 15:52, Roger Riggs wrote:
- || valObj instanceof Long
- || valObj instanceof Integer
- || valObj instanceof Float
- || valObj instanceof Double
- ||
Please review a minor cleanup to remove code long since unnecessary.
The type of the BadAttributeValueExpException argument is String and
if it is not a string in the serialized stream, a suitable replacement
is created.
Issue: https://bugs.openjdk.java.net/browse/JDK-8232622
Patch:
diff
