Hi Chris and Serguei,
Thanks for the review, I will add the appropriate noreg label.
Thanks,
Fairoz
From: Serguei Spitsyn
Sent: Wednesday, July 25, 2018 11:24 PM
To: Chris Plummer ; Fairoz Matte
; serviceability-dev@openjdk.java.net
Subject: Re: [8u-backport] RFR: JDK-8191948: jdb error
Hi Fairoz,
Looks good to me too.
Thank you for taking care about this backport!
On 7/25/18 10:31, Chris Plummer wrote:
Hi
Fairoz,
The changes look good. I'm not sure what the policy is when part
of the (full)
Hi Fairoz,
The changes look good. I'm not sure what the policy is when part of the
(full) backport contains test changes that aren't directly applicable to
8u. You might need some sort of noreg label on the backport CR.
thanks,
Chris
On 7/25/18 1:23 AM, Fairoz Matte wrote:
Hi,
Kindly revi
Hi,
Kindly review the backport of "JDK-8191948: jdb error: InvalidTypeException:
Can't assign double[][][] to double[][][]" to 8u
Webrev - http://cr.openjdk.java.net/~fmatte/8191948/webrev.00/
JDK 11 bug - https://bugs.openjdk.java.net/browse/JDK-8191948
JDK 11 changeset - http://hg.openj
Thank you, Alex and Serguei for reviewing this change!
Best regards,
Daniil
On 7/12/18, 11:21 AM, "Alex Menkov" wrote:
+1
--alex
On 07/11/2018 22:26, serguei.spit...@oracle.com wrote:
> Hi Daniil,
>
> It looks good.
>
> Thanks,
> Serguei
>
+1
--alex
On 07/11/2018 22:26, serguei.spit...@oracle.com wrote:
Hi Daniil,
It looks good.
Thanks,
Serguei
On 7/11/18 22:23, Daniil Titov wrote:
Please review the changes that fix jdb issue with evaluation of
multidimensional arrays of primitives.
The problem here is that for N-dimension
Hi Daniil,
It looks good.
Thanks,
Serguei
On 7/11/18 22:23, Daniil Titov wrote:
Please review the changes that fix jdb issue with evaluation of
multidimensional arrays of primitives.
The problem here is that for N-dimensional arrays of the primitives with N
greater then 2, JDI fails to fin
Please review the changes that fix jdb issue with evaluation of
multidimensional arrays of primitives.
The problem here is that for N-dimensional arrays of the primitives with N
greater then 2, JDI fails to find its component type (which is an array of
dimension N-1) assuming that it is a boot
