RE: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-03-02 Thread Langer, Christoph
Thank you, Steven. I just took the bug. Thanks Volker and Chris for reviewing. I just posted in 8u-dev for approval... Best regards Christoph > -Original Message- > From: Stephen Fitch [mailto:stephen.fi...@oracle.com] > Sent: Montag, 26. Februar 2018 21:31 > To: Chris Plummer

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Stephen Fitch
Happy to see this get done (ahead of when I can get to it) feel free to take the JBS backport back into your name Christoph. s. On 2/26/18 11:22 AM, Chris Plummer wrote: I'm not sure the old code was doing anything useful by essentially checking for jdwpMajor == 0. When was it ever zero?

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Chris Plummer
I'm not sure the old code was doing anything useful by essentially checking for jdwpMajor == 0. When was it ever zero? Chris On 2/26/18 2:28 AM, Volker Simonis wrote: Hi Christoph, I think the new code is wrong for "jdwpMajor == 0", which was correctly handled before. But I'm not sure if

Re: 8u: RFR(S): 8197943: Unable to use JDWP API in JDK 8 to debug JDK 9 VM

2018-02-26 Thread Volker Simonis
Hi Christoph, I think the new code is wrong for "jdwpMajor == 0", which was correctly handled before. But I'm not sure if that is relevant at all nowadays and taking into account that this is a verbatim downport from 9 I don't think we have to do better in 8u. Otherwise looks good from my side.