Re: Let jvmtiGen exit with a non-zero exit code upon failure

Looks good! Thanks, /Staffan > On 2 nov. 2015, at 19:54, Carsten Varming wrote: > > Dear Staffan, > > I updated the webrev at http://cr.openjdk.java.net/~cvarming/jvmtiGen.02/ > > > I kept the verbose flag to avoid printing the fallback war

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Hi Carsten, The fix looks good to me. Thank you for the update! I'm waiting for a reply and thumbs up from Staffan. Thanks, Serguei On 11/2/15 10:54, Carsten Varming wrote: Dear Staffan, I updated the webrev at http://cr.openjdk.java.net/~cvarming/jvmtiGen.02/

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Dear Staffan, I updated the webrev at http://cr.openjdk.java.net/~cvarming/jvmtiGen.02/ I kept the verbose flag to avoid printing the fallback warnings. Carsten On Mon, Nov 2, 2015 at 8:34 AM, Carsten Varming wrote: > Dear Staffan, > > Stacktraces: I can see your point. I'll add them back unc

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Dear Staffan, Stacktraces: I can see your point. I'll add them back unconditionally. Warnings: The OpenJDK build gets a little noisy when you start printing warnings. The fallback on failed includes in hotspot/src/share/vm/trace/*.xml cause a lot of printing; see below. That is why I introduced t

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Hi Carsten, Thanks for spending the time on this - this version looks a lot cleaner. I would prefer to always print the exception stack trace. The reason is that if something goes wrong, it will likely happen on a build server where it isn’t simple to find and insert the extra ‘-verbose’ flag.

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Dear Serguei and Steffan, Sorry about the late reply. The office was a little busy Friday. Steffan's suggestion is to remove all the exception handling code sound reasonable. I am not a fan of the main method throwing checked exceptions, so I wrapped all the exception handling into a tiny handler

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Agreed. This makes sense. Carsten, Does this approach looks better to you? If so, could you, please, change your webrev accordingly? I do not want to push a different fix under your name. Thanks, Serguei On 10/30/15 04:33, Staffan Larsen wrote: I realize now that the code can be simplified ev

Re: Let jvmtiGen exit with a non-zero exit code upon failure

I realize now that the code can be simplified even more. If we remove all the exception-catches and just let any exceptions propagate out of main(), then the java executable will terminate with a non-zero exit value if an exception is thrown. I don’t think the code in the exception handlers add

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Carsten, The fix looks good. I'll push it as soon as I get a time. New bug filed: https://bugs.openjdk.java.net/browse/JDK-8141035 Feel free to update it if necessary. Thanks, Serguei On 10/29/15 17:00, Carsten Varming wrote: Dear Serguei and Steffan, Thank you for the reviews. I have up

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Carsten, I forgot to thank you for taking care about this issue! Thanks, Serguei On 10/29/15 15:41, serguei.spit...@oracle.com wrote: Hi Carsten, The fix looks good. I share the Staffan's comments though. If understand correctly, you do not have an openjdk author status yet. I will sponsor y

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Hi Carsten, The fix looks good. I share the Staffan's comments though. If understand correctly, you do not have an openjdk author status yet. I will sponsor your fix. Please, let me know the bug ID after you create one. Thanks, Serguei Please, let me know On 10/29/15 14:22, Staffan Larsen w

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Dear Serguei and Steffan, Thank you for the reviews. I have updated the webrev at http://cr.openjdk.java.net/~cvarming/jvmtiGen . I haven't been able to log into JBS yet, so please go ahead and create bug id for this change. Dan: Thank you for forwarding this email to the proper alias. Carsten

Re: Let jvmtiGen exit with a non-zero exit code upon failure

Carsten, This looks good with a few comments: 1) If you make the “verbose” variable into a static field, you can avoid the final-copying. 2) nit: Line 216: put "System.exit(1);” on it’s own line Oh, and create a bug: https://bugs.openjdk.java.net Thanks, /Staffan > On 29 okt. 2015, at 14:54,

Re: Let jvmtiGen exit with a non-zero exit code upon failure

JVM/TI belongs to the Serviceability team so adding serviceability-dev@... Dan On 10/28/15 8:45 PM, Carsten Varming wrote: webrev: http://cr.openjdk.java.net/~cvarming/jvmtiGen/ bug: ? jvmtiGen is used to process a number of xml and xslt files in OpenJDK. Currently jvmtiGen exits with exit c