Re: Number of CMS collections and the JMM GC counters

2011-07-28 Thread Krystal Mok
Hi Ramki and Kevin, Kevin, yes, it would be great if you could verify this and push the fix. > I am not sure if the push would need to wait for the signing of OCA > from Kris, but best to check with Those Who Would Know Such Things. It'll take some time before we can sign the OCA. I heard that th

Re: Number of CMS collections and the JMM GC counters

2011-07-28 Thread Y. S. Ramakrishna
I filed: 7072527 CMS: JMM GC counters overcount in some cases On 07/28/11 17:29, Y. S. Ramakrishna wrote: Hi Kevin -- thanks for jumping on this! More inline below ... On 07/28/11 09:33, Krystal Mok wrote: Hi Kevin, Thank you for taking care of this, and it's good to see the problem is veri

Re: Number of CMS collections and the JMM GC counters

2011-07-28 Thread Y. S. Ramakrishna
Hi Kevin -- thanks for jumping on this! More inline below ... On 07/28/11 09:33, Krystal Mok wrote: Hi Kevin, Thank you for taking care of this, and it's good to see the problem is verified. I think whether or not the suggested fix is sufficient depends on what paths can reach CMSCollector

Re: Number of CMS collections and the JMM GC counters

2011-07-27 Thread Krystal Mok
Hi Ramki, I agree with your analysis and will review & shepherd your suggested fix. > I'll file a CR to cover this fix and send out a CR id shortly. Thank you ^_^ If the suggested fix does fix the problem, then there's more code that can probably go away as well: (diff against HS20) diff -r f0f

Re: Number of CMS collections and the JMM GC counters

2011-07-27 Thread Y. Srinivas Ramakrishna
Hi Kris -- I agree with your analysis and will review & shepherd your suggested fix. I'll file a CR to cover this fix and send out a CR id shortly. Thanks for the fix. If you have not already done so, please complete the contributor agreement (OCA) so that your contribution may be used; see:-

Re: Number of CMS collections and the JMM GC counters

2011-07-27 Thread Y. Srinivas Ramakrishna
Cross-posting to serviceability-dev list. Please include both lists in your responses to this thread. -- ramki On 7/27/2011 9:12 AM, Krystal Mok wrote: Hi all, I've been looking at a strange inconsistency of full GC count recorded by jvmstat and JMM counters. I'd like to know which ones of the