Re: PerfData counter: sun.gc.policy.generations in JDK 8

Sorry this fell off my plate. I'll dig up the test Jon pointed me to and see how i can write one for this, then update the old webrev. I'll try and get that done in the next few days. thanks for the reminder! \ -- ramki On Fri, Apr 15, 2016 at 6:43 AM, Stefan Karlsson wrote: > Hi Ramki and Jon

Re: PerfData counter: sun.gc.policy.generations in JDK 8

Hi Ramki and Jon, What's the status of this review thread? The bug is still open and targeted for JDK 9. Thanks, StefanK On 2015-06-03 08:15, Srinivas Ramakrishna wrote: Thanks Jon for the review and the pointer to the test. I'll get back to you later this week with a suitable test. -- Ram

Re: PerfData counter: sun.gc.policy.generations in JDK 8

Thanks Jon for the review and the pointer to the test. I'll get back to you later this week with a suitable test. -- Ramki ysr1729 > On Jun 2, 2015, at 14:16, Jon Masamitsu wrote: > > Ramki, > > Changes look good. > > I'm guessing you tested by generating the > perfdata by hand and verifyin

Re: PerfData counter: sun.gc.policy.generations in JDK 8

Ramki, Changes look good. I'm guessing you tested by generating the perfdata by hand and verifying the contents of the perfdata. Do you think a test can be written to verify the change? If you look at test/gc/metaspace/TestMetaspacePerfCounters.java in your repository I think that is an exa

Re: PerfData counter: sun.gc.policy.generations in JDK 8

Thanks for the review of the patch for 8-dev (from the ticket), Staffan. Sorry for the delay in getting the official webrev out -- it took me a while to first get set up with an hs9 repo (thanks Jon!) and then get my openjdk credentials updated (thanks Mark!). Here's the webrev against hs9 for of

Internal - RE: PerfData counter: sun.gc.policy.generations in JDK 8

-dev@openjdk.java.net serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net Subject: Re: PerfData counter: sun.gc.policy.generations in JDK 8 Looks like a good patch to me. /Staffan On 14 maj 2015, at 18:12, Srinivas Ramakrishna mailto:ysr1...@gmail.com"ysr1...@gmai

Re: PerfData counter: sun.gc.policy.generations in JDK 8

Looks like a good patch to me. /Staffan > On 14 maj 2015, at 18:12, Srinivas Ramakrishna wrote: > > https://bugs.openjdk.java.net/browse/JDK-8080345 > > > > > On Wed, May 13, 2015 at 1:08 PM, Srinivas Ramakrishna

Re: PerfData counter: sun.gc.policy.generations in JDK 8

https://bugs.openjdk.java.net/browse/JDK-8080345 On Wed, May 13, 2015 at 1:08 PM, Srinivas Ramakrishna wrote: > > With perm gen going away (and being replaced by metaspace) in JDK 8, it > makes sense that the counter > sun.gc.policy.generations should be "2", rather than "3". However, in JDK >