Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Staffan, Thanks for the review! // Katja On 04/28/2015 02:05 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 24 apr 2015, at 16:17, Yekaterina Kantserova > wrote: All suggestions have been implemented. Please find new webrevs here: webre

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Looks good! Thanks, /Staffan > On 24 apr 2015, at 16:17, Yekaterina Kantserova > wrote: > > All suggestions have been implemented. Please find new webrevs here: > > webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.02 >

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

All suggestions have been implemented. Please find new webrevs here: webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.02 webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.02 webrev hotspot: http://cr.openjdk.java.net/~ykantser/8059047.hotspot/webrev.01 // Katj

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

> On 24 apr 2015, at 11:34, Yekaterina Kantserova > wrote: > > Hi, > > Here comes the updated version. > > bug: https://bugs.openjdk.java.net/browse/JDK-8059047 > > webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.01/ > webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Hi, Here comes the updated version. bug: https://bugs.openjdk.java.net/browse/JDK-8059047 webrev root: http://cr.openjdk.java.net/~ykantser/8059047/webrev.01/ webrev jdk: http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.01/ webrev hotspot: http://cr.openjdk.java.net/~ykantser/8059047.ho

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

a.net Sent: Wednesday, April 22, 2015 3:09:35 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests Oh, and: serviceability/dcmd/gc/HeapDumpTest.java > On 22 apr 2015, at 15:06, Staffan Larsen wrote

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Oh, and: serviceability/dcmd/gc/HeapDumpTest.java > On 22 apr 2015, at 15:06, Staffan Larsen wrote: > > I also found this test that uses jhat and needs an update: > com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh > > /Staffan > >> On 22 apr 2015, at 15:05, Staffan Larsen wrote: >> >>

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

I also found this test that uses jhat and needs an update: com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh /Staffan > On 22 apr 2015, at 15:05, Staffan Larsen wrote: > > I think you are missing a "@build jdk.test.lib.hprof..*”. > > /Staffan > >> On 22 apr 2015, at 14:25, Yekaterina Ka

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

I think you are missing a "@build jdk.test.lib.hprof..*”. /Staffan > On 22 apr 2015, at 14:25, Yekaterina Kantserova > wrote: > > Staffan, thank you for the review! > > This issue needs a change in jdk as well. > http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.00 - > BasicJMapTest.j

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Staffan, thank you for the review! This issue needs a change in jdk as well. http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.00 - BasicJMapTest.java will use HprofParser to verify hprof dumps created by the test. // Katja On 04/22/2015 01:20 PM, Staffan Larsen wrote: Looks good!

Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Looks good! Thanks, /Staffan > On 22 apr 2015, at 11:17, Yekaterina Kantserova > wrote: > > Hi, > > Could I please have a review of this fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-8059047 > webrev: http://cr.openjdk.java.net/~ykantser/8059047/webrev.00/ > > This fix is a part of