Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-05 Thread David Holmes
Seems good to go to me. David On 5/09/2013 10:52 PM, Jaroslav Bachorik wrote: On 09/04/2013 10:33 AM, Jaroslav Bachorik wrote: On 09/04/2013 10:29 AM, David Holmes wrote: On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote: On 09/04/2013 04:24 AM, Mandy Chung wrote: Hi Jaroslav, Like Daniel and

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-05 Thread Jaroslav Bachorik
On 09/04/2013 10:33 AM, Jaroslav Bachorik wrote: > On 09/04/2013 10:29 AM, David Holmes wrote: >> On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote: >>> On 09/04/2013 04:24 AM, Mandy Chung wrote: Hi Jaroslav, Like Daniel and David said, CyclicBarrier and other j.u.concurrent utility

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-04 Thread Jaroslav Bachorik
On 09/04/2013 10:29 AM, David Holmes wrote: > On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote: >> On 09/04/2013 04:24 AM, Mandy Chung wrote: >>> Hi Jaroslav, >>> >>> Like Daniel and David said, CyclicBarrier and other j.u.concurrent >>> utility seem a good replacement with the ThreadExecutionSynchron

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-04 Thread David Holmes
On 4/09/2013 4:56 PM, Jaroslav Bachorik wrote: On 09/04/2013 04:24 AM, Mandy Chung wrote: Hi Jaroslav, Like Daniel and David said, CyclicBarrier and other j.u.concurrent utility seem a good replacement with the ThreadExecutionSynchronizer class. ThreadMXBean/Locks.java was written prior to j.u

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-03 Thread Jaroslav Bachorik
On 09/04/2013 04:24 AM, Mandy Chung wrote: > Hi Jaroslav, > > Like Daniel and David said, CyclicBarrier and other j.u.concurrent > utility seem a good replacement with the ThreadExecutionSynchronizer > class. ThreadMXBean/Locks.java was written prior to j.u.concurrent > added to the platform (bot

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-03 Thread Mandy Chung
Hi Jaroslav, Like Daniel and David said, CyclicBarrier and other j.u.concurrent utility seem a good replacement with the ThreadExecutionSynchronizer class. ThreadMXBean/Locks.java was written prior to j.u.concurrent added to the platform (both java.util.concurrent and java.lang.management we

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-03 Thread David Holmes
Hi Jaroslav, On 3/09/2013 11:02 PM, Jaroslav Bachorik wrote: On 09/03/2013 02:10 PM, Daniel Fuchs wrote: Hi Jaroslav, Have you considered replacing the ThreadExecutionSynchronizer with a plain (and more reliable) CyclicBarrier or Phaser object?

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-03 Thread Jaroslav Bachorik
On 09/03/2013 02:10 PM, Daniel Fuchs wrote: > Hi Jaroslav, > > Have you considered replacing the ThreadExecutionSynchronizer with > a plain (and more reliable) CyclicBarrier or Phaser object? > > > >

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-03 Thread Erik Gahlin
Looks good, but I think it's better for tests to spin forever if they can't reach a state and let the test harness deal with it, but I'm fine with it, since it was that way before. Erik Jaroslav Bachorik skrev 2013-09-03 13:15: Please, review the following patch of the intermittently failin

Re: RFR: 6815130 intermittent ThreadMXBean/Locks.java failure

2013-09-03 Thread Daniel Fuchs
Hi Jaroslav, Have you considered replacing the ThreadExecutionSynchronizer with a plain (and more reliable) CyclicBarrier or Phaser object?