On 11 jun 2014, at 14:57, Alan Bateman wrote:
> On 11/06/2014 09:08, Staffan Larsen wrote:
>>
>> I added:
>>
>> + * @throws IllegalArgumentException
>> + * If keys or values in agentProperties are invalid.
>> + *
> That is probably okay for now, thanks.
>
>
>> :
>>
>>
On 11/06/2014 09:08, Staffan Larsen wrote:
I added:
+ * @throws IllegalArgumentException
+ * If keys or values in agentProperties are invalid.
+ *
That is probably okay for now, thanks.
:
I would prefer to leave them in as they do no harm for non-Eclipse users and
ar
On 11 jun 2014, at 08:58, Alan Bateman wrote:
> On 10/06/2014 08:46, Staffan Larsen wrote:
>>
>> Changed: http://cr.openjdk.java.net/~sla/8044135/webrev.02/
>>
>>
> I took another pass over this (webrev.03, latest I think).
>
> Now that the NPE issue is resolved then I think it means that
>
On 10/06/2014 08:46, Staffan Larsen wrote:
Changed: http://cr.openjdk.java.net/~sla/8044135/webrev.02/
I took another pass over this (webrev.03, latest I think).
Now that the NPE issue is resolved then I think it means that
VirtualMachine#startManagementAgent needs to @throws
IllegalArgume
On 10 jun 2014, at 14:07, Daniel Fuchs wrote:
> Hi Staffan,
>
> In:
> http://cr.openjdk.java.net/~sla/8044135/webrev.00/src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java.frames.html
>
> line 190, I wonder whether some escape mechanism should
> be put in place for entry.getValue().
Hi Staffan,
In:
http://cr.openjdk.java.net/~sla/8044135/webrev.00/src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java.frames.html
line 190, I wonder whether some escape mechanism should
be put in place for entry.getValue().
Do you have the guarantee that entry.getValue() will never co
On 10 jun 2014, at 09:40, Alan Bateman wrote:
> On 10/06/2014 08:09, Staffan Larsen wrote:
>> :
>>
>>
>> An updated webrev is here: http://cr.openjdk.java.net/~sla/8044135/webrev.01/
> To David's point about IAE vs. NPE then this API throws NPE when passed a
> null so it would be good to keep
On 10/06/2014 08:09, Staffan Larsen wrote:
:
An updated webrev is here: http://cr.openjdk.java.net/~sla/8044135/webrev.01/
To David's point about IAE vs. NPE then this API throws NPE when passed
a null so it would be good to keep that consistent.
I don't think I've come across @SuppressedWar
On 10/06/2014 5:09 PM, Staffan Larsen wrote:
On 10 jun 2014, at 08:30, David Holmes wrote:
A few general comments:
VirtualMachine.java:
- Can/should these references be links to external docs?
_See the online documentation for "Monitoring and Management Using JMX
Technology" for further de
On 10 jun 2014, at 08:30, David Holmes wrote:
> Hi Staffan,
>
> A few general comments:
>
> VirtualMachine.java:
>
> - Can/should these references be links to external docs?
>
> _See the online documentation for "Monitoring and Management Using JMX
> Technology" for further details._
Good
On 9 jun 2014, at 21:54, Alan Bateman wrote:
> On 09/06/2014 20:03, Staffan Larsen wrote:
>> This is the first part in a two-part series of removing the
>> management-agent.jar and replacing its functionality with APIs in the attach
>> framework. In this change I have added the new APIs, a lat
Hi Staffan,
A few general comments:
VirtualMachine.java:
- Can/should these references be links to external docs?
_See the online documentation for "Monitoring and Management Using JMX
Technology" for further details._
startManagementAgent(Properties agentProperties) should specify what
ha
On 09/06/2014 20:03, Staffan Larsen wrote:
This is the first part in a two-part series of removing the
management-agent.jar and replacing its functionality with APIs in the attach
framework. In this change I have added the new APIs, a later change will remove
management-api.jar.
management-ag
13 matches
Mail list logo
