Re: RFR: 8139564: Convert TraceDefaultMethods to Unified Logging

2015-10-19 Thread Rachel Protacio
Please see updated webrev http://cr.openjdk.java.net/~rprotacio/8139564.02/ with the following changes: - repositioned and deleted ResourceMark's, as per Harold's suggestions - fixed copyright year in test file - moved update_position() line in ostream.cpp because it was breaking indentation in

Re: RFR: 8139564: Convert TraceDefaultMethods to Unified Logging

2015-10-19 Thread Marcus Larsson
Hi, On 2015-10-16 18:21, Coleen Phillimore wrote: Hi, I added the serviceability group so they can comment on this as well. I think having logging in the PRODUCT build is requested so that we can more easily debug customer problems. That said, we will not enable logging in product if we

Re: RFR: 8139564: Convert TraceDefaultMethods to Unified Logging

2015-10-16 Thread Coleen Phillimore
Hi, I added the serviceability group so they can comment on this as well. I think having logging in the PRODUCT build is requested so that we can more easily debug customer problems. That said, we will not enable logging in product if we see any performance problem. Also for some options