Re: RFR: 8143229: Replace the develop level with develop macros in Unified Logging

2015-11-23 Thread Marcus Larsson
Hey all, You're right, keeping this on info level makes more sense. I'll fix this before pushing. Thanks for reviewing! Regards, Marcus On 2015-11-23 05:56, David Holmes wrote: On 21/11/2015 7:58 AM, Coleen Phillimore wrote: Hi Marcus, This looks good, except I have one question: http://c

Re: RFR: 8143229: Replace the develop level with develop macros in Unified Logging

2015-11-20 Thread Bengt Rutisson
Hi Marcus, On 2015-11-20 12:58, Marcus Larsson wrote: Hi, Please review the following patch to replace the previous 'develop' level with macros, in the unified logging framework. The macros are essentially regular log calls inside a #ifndef PRODUCT. In the product they do nothing / return fa

Re: RFR: 8143229: Replace the develop level with develop macros in Unified Logging

2015-11-20 Thread Marcus Larsson
Thank you for reviewing, Bengt! Marcus On 2015-11-20 13:09, Bengt Rutisson wrote: Hi Marcus, On 2015-11-20 12:58, Marcus Larsson wrote: Hi, Please review the following patch to replace the previous 'develop' level with macros, in the unified logging framework. The macros are essentially re