Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread mandy chung
On 5/31/18 11:14 AM, Stefan Karlsson wrote: Right. The ZGC patch has a @requires vm.gc != "Z" row in MemoryTest.java. Ah. This change is fine then. Mandy

Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread Stefan Karlsson
On 2018-05-31 20:09, mandy chung wrote: On 5/31/18 10:36 AM, Stefan Karlsson wrote: Hi Mandy, On 2018-05-31 18:19, mandy chung wrote: Hi Stefan, This change looks okay.  Can you add a comment to describe the expected memory pools for ZGC so that it explains why the min number of heap memo

Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread mandy chung
On 5/31/18 10:36 AM, Stefan Karlsson wrote: Hi Mandy, On 2018-05-31 18:19, mandy chung wrote: Hi Stefan, This change looks okay.  Can you add a comment to describe the expected memory pools for ZGC so that it explains why the min number of heap memory pools is 1. I think this test and p

Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread Stefan Karlsson
Hi Mandy, On 2018-05-31 18:19, mandy chung wrote: Hi Stefan, This change looks okay.  Can you add a comment to describe the expected memory pools for ZGC so that it explains why the min number of heap memory pools is 1. I think this test and possibly other memory pool tests should be re-ex

Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread mandy chung
Hi Stefan, This change looks okay. Can you add a comment to describe the expected memory pools for ZGC so that it explains why the min number of heap memory pools is 1. I think this test and possibly other memory pool tests should be re-examined and determine what proper verification should

Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread Stefan Karlsson
Thanks, Erik. StefanK On 2018-05-31 16:26, Erik Österlund wrote: Hi Stefan, Looks good. Thanks, /Erik On 2018-05-31 15:53, Stefan Karlsson wrote: Hi all, Please review this patch to lower the minimum number of heap memory pools in MemoryTest.java. http://cr.openjdk.java.net/~stefank/820

Re: RFR: 8204173: Lower the minimum number of heap memory pools in MemoryTest.java

2018-05-31 Thread Erik Österlund
Hi Stefan, Looks good. Thanks, /Erik On 2018-05-31 15:53, Stefan Karlsson wrote: Hi all, Please review this patch to lower the minimum number of heap memory pools in MemoryTest.java. http://cr.openjdk.java.net/~stefank/8204173/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8204173 Ju