On Wed, 3 Mar 2021 02:08:15 GMT, Yasumasa Suenaga wrote:
> I think we should remove `main()` from CLHSDB/HSDB to be honest because they
> are called from SALauncher, and we cannot call them directly because they are
> not exported in module-info.
Yes, I'm starting to come to the same conclusio
On Wed, 3 Mar 2021 02:32:04 GMT, Yasumasa Suenaga wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java line 100:
>>
>>> 98: execPath = null;
>>> 99: coreFilename = null;
>>> 100: remoteMachineName = null;
>>
>> In general it's not clear to me why HSDB.java needed
On Tue, 2 Mar 2021 22:24:17 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java line 100:
>
>> 98: execPath = n
On Tue, 2 Mar 2021 21:48:30 GMT, Chris Plummer wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments
>
> src/jdk.hotspot.agent/doc/clhsdb.html line 39:
>
>> 37: Available commands:
>> 38: assert true
On Tue, 2 Mar 2021 22:31:22 GMT, Chris Plummer wrote:
> This pre-existing code in CLHSDB.java is a little concerning:
>
> ```
> 127 private void doUsage() {
> 128 System.out.println("Usage: java CLHSDB [[pid] |
> [path-to-java-executable [path-to-corefile]] | help ]");
> 129
On Tue, 2 Mar 2021 12:55:04 GMT, Yasumasa Suenaga wrote:
>> `attach` command on CLHSDB supports to attach live process (PID) and
>> coredump, but it cannot connect to debug server. CLHSDB does not have a
>> command to connect to debug server.
>>
>> Other jhsdb commands (jstack, jmap, etc...) c
> `attach` command on CLHSDB supports to attach live process (PID) and
> coredump, but it cannot connect to debug server. CLHSDB does not have a
> command to connect to debug server.
>
> Other jhsdb commands (jstack, jmap, etc...) can connect debug server via
> `--connect` option, so CLHSDB sho
