On Mon, 22 Mar 2021 23:08:09 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix Hashtable constructor and comments.
>
> Marked as reviewed by iklam (Reviewer).
Thanks Lois and Ioi!
On Mon, 22 Mar 2021 22:48:05 GMT, Coleen Phillimore wrote:
>> From CR:
>> The useful/general BasicHashtable uses a block allocation scheme to
>> reportedly reduce fragmentation. When the StringTable and SymbolTable used
>> to use this hashtable, performance benefits were reportedly observed bec
> From CR:
> The useful/general BasicHashtable uses a block allocation scheme to
> reportedly reduce fragmentation. When the StringTable and SymbolTable used to
> use this hashtable, performance benefits were reportedly observed because of
> the block allocation scheme. Since these tables were m
On Mon, 22 Mar 2021 21:58:09 GMT, Ioi Lam wrote:
>> Yes, I'd like to make the constructors initialize the fields, but didn't
>> know what to do about this block zeroing code. Would you have to add it
>> back with deterministic GC?
>
>> Yes, I'd like to make the constructors initialize the fiel
On Mon, 22 Mar 2021 21:54:23 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/utilities/hashtable.cpp line 64:
>>
>>> 62:
>>> 63: if (DumpSharedSpaces) {
>>> 64: // Avoid random bits in structure padding so we can have
>>> deterministic content in CDS archive
>>
>> Hmm, the sequence l
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote:
> From CR:
> The useful/general BasicHashtable uses a block allocation scheme to
> reportedly reduce fragmentation. When the StringTable and SymbolTable used to
> use this hashtable, performance benefits were reportedly observed because
On Mon, 22 Mar 2021 21:42:51 GMT, Ioi Lam wrote:
>> From CR:
>> The useful/general BasicHashtable uses a block allocation scheme to
>> reportedly reduce fragmentation. When the StringTable and SymbolTable used
>> to use this hashtable, performance benefits were reportedly observed because
>> o
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote:
> From CR:
> The useful/general BasicHashtable uses a block allocation scheme to
> reportedly reduce fragmentation. When the StringTable and SymbolTable used to
> use this hashtable, performance benefits were reportedly observed because
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote:
> From CR:
> The useful/general BasicHashtable uses a block allocation scheme to
> reportedly reduce fragmentation. When the StringTable and SymbolTable used to
> use this hashtable, performance benefits were reportedly observed because
