Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-18 Thread Gary Adams
On 10/17/18, 6:46 PM, Alex Menkov wrote: Hi Gary, - RedefineCrossEvent.java: you can drop "@modules jdk.jdi" as well. jdk.jdi is added to all test in the dir (it's specified in test/jdk/com/sun/jdi/TEST.properties) Done. about InstanceFilter test - it's strange that RedefineCrossEvent fails

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-18 Thread Gary Adams
So far I have not seen the timeout in my current test runs. Since the test has been on the ProblemList for 1.5 years we would not have seen any timeouts recently. The test does run through a large number of tests that formerly relied on java ee modules, so may have been running longer in the past

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-17 Thread serguei.spit...@oracle.com
Hi Gary, With the suggest tweaks below the fix looks good to me (modulo suggestions from Alex in the following message). I'm Okay with any approach related to the problem list. It looks wrong to keep the test problem listed with the same bug id. If we want to keep it then the bug id needs to be

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-17 Thread Alex Menkov
Hi Gary, - RedefineCrossEvent.java: you can drop "@modules jdk.jdi" as well. jdk.jdi is added to all test in the dir (it's specified in test/jdk/com/sun/jdi/TEST.properties) about InstanceFilter test - it's strange that RedefineCrossEvent fails while InstanceFilter does not. Maybe it's caus

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-17 Thread Chris Plummer
On 10/17/18 12:40 PM, gary.ad...@oracle.com wrote: On 10/17/18 2:04 PM, Chris Plummer wrote: Hi Gary, Can this be on one line now:   30  * @modules   31  *  jdk.jdi OK What are you blocking all jdk.* classes from redef when you pointed out that only jdk.internal.* is an issue? The

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-17 Thread gary.ad...@oracle.com
On 10/17/18 2:04 PM, Chris Plummer wrote: Hi Gary, Can this be on one line now:   30  * @modules   31  *  jdk.jdi OK What are you blocking all jdk.* classes from redef when you pointed out that only jdk.internal.* is an issue? The file I'm modifying already has some blocking checks

Re: RFR: JDK-8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

2018-10-17 Thread Chris Plummer
Hi Gary, Can this be on one line now:   30  * @modules   31  *  jdk.jdi What are you blocking all jdk.* classes from redef when you pointed out that only jdk.internal.* is an issue? Is this also addressing JDK-8180804? If not, should it stay on the problem list until JDK-8180804 is