On 4/17/20 4:58 AM, serguei.spit...@oracle.com wrote:
Hi Coleen,
LGTM++
On 4/16/20 18:47, David Holmes wrote:
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI
code. The two that are now stubbed out would have been no-ops without
JVMTI as
On 4/16/20 9:47 PM, David Holmes wrote:
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI code.
The two that are now stubbed out would have been no-ops without JVMTI
as old_compiled_method_table would have been NULL.
Yes, that is true. I considered #if
Hi Coleen,
LGTM++
On 4/16/20 18:47, David Holmes wrote:
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI code.
The two that are now stubbed out would have been no-ops without JVMTI
as old_compiled_method_table would have been NULL.
Still seems trivial to me.
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI code.
The two that are now stubbed out would have been no-ops without JVMTI as
old_compiled_method_table would have been NULL.
Still seems trivial to me.
Thanks,
David
On 17/04/2020 1:14 am,
On 4/16/20 10:24 AM, Magnus Ihse Bursie wrote:
On 2020-04-16 04:37, coleen.phillim...@oracle.com wrote:
On 4/15/20 9:37 PM, David Holmes wrote:
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at
On 2020-04-16 04:37, coleen.phillim...@oracle.com wrote:
On 4/15/20 9:37 PM, David Holmes wrote:
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at
http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link
On 4/15/20 9:37 PM, David Holmes wrote:
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at
http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8242896
Looks good but ...
Built and ran vmTestbase
Hi Coleen,
On 16/04/2020 10:59 am, coleen.phillim...@oracle.com wrote:
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8242896.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8242896
Looks good but ...
Built and ran vmTestbase RedefineTests which use the protected code.