Hi Daniil,
It looks good.
I've consulted with Igor Ignatyev, and he suggested exactly the same
approach.
Thanks,
Serguei
On 3/13/18 22:26, Daniil Titov wrote:
Please review the changes that fix intermittent timeout failure of
serviceability/dcmd/framework/* tests.
The problem here is that
Confirming good to go.
David
On 15/03/2018 3:26 AM, Chris Plummer wrote:
Hi Daniil,
I believe David said he would defer to me on whether you should take the
approach of spawning a different app to avoid this issue. I'm fine with
it the way it is, so unless you feel compelled to take the more
Hi Daniil,
I believe David said he would defer to me on whether you should take the
approach of spawning a different app to avoid this issue. I'm fine with
it the way it is, so unless you feel compelled to take the more
complicated approach, I think you're good to go.
thanks,
Chris
On 3/14
Hi Chris and David,
Could you please say is anything else required or you are OK with these
changes?
As Chris already replied there are only 3 tests that will be affected
and each of them takes less than 5 seconds to complete.
On 3/13/18 10:50 PM, Chris Plummer wrote:
Hi Danill,
The fix
On 14/03/2018 4:49 PM, Chris Plummer wrote:
On 3/13/18 10:54 PM, David Holmes wrote:
Hi Daniil,
On 14/03/2018 3:26 PM, Daniil Titov wrote:
Please review the changes that fix intermittent timeout failure of
serviceability/dcmd/framework/* tests.
The problem here is that these tests invoke jcm
On 3/13/18 10:54 PM, David Holmes wrote:
Hi Daniil,
On 14/03/2018 3:26 PM, Daniil Titov wrote:
Please review the changes that fix intermittent timeout failure of
serviceability/dcmd/framework/* tests.
The problem here is that these tests invoke jcmd in different ways
and one of such ways is
Hi Daniil,
On 14/03/2018 3:26 PM, Daniil Titov wrote:
Please review the changes that fix intermittent timeout failure of
serviceability/dcmd/framework/* tests.
The problem here is that these tests invoke jcmd in different ways and one of
such ways is when a main class is passed to the jcmd as
Hi Danill,
The fix looks good. Were you able to reproduce this problem, and then
after the fix run the tests enough times to be confident this really
resolves the issue?
Are you going to close JDK-8194057 as a dup?
thanks,
Chris
On 3/13/18 10:26 PM, Daniil Titov wrote:
Please review the c
