Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

2017-06-19 Thread serguei.spit...@oracle.com
Thumbs up. Thanks, Serguei On 6/19/17 13:34, Mandy Chung wrote: + * On Jun 19, 2017, at 1:31 PM, serguei.spit...@oracle.com wrote: On 6/19/17 13:23, Mandy Chung wrote: On Jun 19, 2017, at 1:17 PM, serguei.spit...@oracle.com wrote: Hi Mandy, I've built the docs with your patch and the li

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

2017-06-19 Thread Mandy Chung
+ * >>> Is it 9 or 10? >>> >> I want to fix this simple docs bug in JDK 9. > > Ok, thanks. > > -Serguei > >> >> Mandy >> >>> Thanks, >>> Serguei >>> >>> >>> On 6/19/17 12:47, Mandy Chung wrote: Serguei, Can you review this patch fixing the link to JPDA? Mandy >>>

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

2017-06-19 Thread serguei.spit...@oracle.com
On 6/19/17 13:23, Mandy Chung wrote: On Jun 19, 2017, at 1:17 PM, serguei.spit...@oracle.com wrote: Hi Mandy, I've built the docs with your patch and the link is still not resolved. It points to the docs/api/specs/jpda/jpda.html It should point to docs/specs/jpda/jpda.html. I verified in m

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

2017-06-19 Thread Mandy Chung
> On Jun 19, 2017, at 1:17 PM, serguei.spit...@oracle.com wrote: > > Hi Mandy, > > I've built the docs with your patch and the link is still not resolved. > It points to the docs/api/specs/jpda/jpda.html > It should point to docs/specs/jpda/jpda.html. I verified in my build. Are you sure your

Re: Review Request JDK-8181834: Broken link in jdk.jdi module documentation

2017-06-19 Thread serguei.spit...@oracle.com
Hi Mandy, I've built the docs with your patch and the link is still not resolved. It points to the docs/api/specs/jpda/jpda.html But it is resolved if the patch is corrected with: + * Is it 9 or 10? Thanks, Serguei On 6/19/17 12:47, Mandy Chung wrote: Serguei, Can you review this patch