Re: inlining AllocateHeap()

Sorry for the delay. I filed it to JBS and uploaded webrev: JDK-8076212: AllocateHeap() and ReallocateHeap() should be inlined. http://cr.openjdk.java.net/~ysuenaga/JDK-8076212/webrev.00/ Could you review it? > Yasumasa you will need to file a CR and you will need a sponsor to push > your

Re: inlining AllocateHeap()

Hi, That would require more significant changes to NMT I think I think two changes: 1. Remove AllocateHeap(size_t, MEMFLAGS, AllocFailType) . 2. Add "const NativeCallStack&" to argument of ReallocateHeap() . I think that caller of AllocateHeap() and ReallocateHeap() should give PC to them

Re: inlining AllocateHeap()

On 13/03/2015 6:13 PM, Thomas Stüfe wrote: Hi Yasumasa, David, Maybe it would make sense to make the number-of-frames-to-skip-parameter configurable? That would require more significant changes to NMT I think - plus I don't see how it will help if you have to know a-priori whether inlining h

Re: inlining AllocateHeap()

Hi Yasumasa, David, Maybe it would make sense to make the number-of-frames-to-skip-parameter configurable? Because the direct caller of AllocateHeap or os::malloc may also not be interesting but still a generic wrapper. So, the user doing the allocation trace could finetune this parameter to fit

Re: inlining AllocateHeap()

Hi Yasumasa, On 12/03/2015 9:58 PM, Yasumasa Suenaga wrote: Hi all, I tried to use NMT with details option on OpenJDK7 on RHEL6.6, but I got address at AllocateHeap() as malloc() caller. I checked symbol in libjvm.so in OracleJDK8u40 Linux x64, it has AllocateHeap() symbol.