On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field
> could be sucessfully p
On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field
> could be sucessfully p
On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field
> could be sucessfully p
On Sun, 26 Sep 2021 08:07:46 GMT, Lin Zang wrote:
>> test/lib/jdk/test/lib/hprof/parser/Reader.java line 99:
>>
>>> 97: // Possible gziped file, try decompress it and get the
>>> stack trace.
>>> 98: in.close();
>>> 99: String deCompressedFile = "
On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field
> could be sucessfully p
On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field
> could be sucessfully p
On Wed, 22 Sep 2021 20:24:09 GMT, Chris Plummer wrote:
>> The class `GzipRandomAccess` is used to parse heap dump file generated from
>> `jcmd`/`jmap` tools when testing.
>> It has the limitation that only gzip file which has "blocksize" header field
>> could
On Thu, 23 Sep 2021 13:07:46 GMT, David Holmes wrote:
>> Thanks @schmelter-sap and @plummercj for your help review and approve this
>> PR!
>> Since this is a non-trivial change, I would like to wait for 2 days before
>> integrate it in case more comments from others.
>
> @linzang this change i
On Tue, 21 Sep 2021 02:07:39 GMT, Lin Zang wrote:
>> I will start reviewing this today.
>
> Thanks @schmelter-sap and @plummercj for your help review and approve this PR!
> Since this is a non-trivial change, I would like to wait for 2 days before
> integrate it in case more comments from others
On Wed, 22 Sep 2021 20:24:09 GMT, Chris Plummer wrote:
>> The class `GzipRandomAccess` is used to parse heap dump file generated from
>> `jcmd`/`jmap` tools when testing.
>> It has the limitation that only gzip file which has "blocksize" header field
>> could
On Wed, 27 Jan 2021 12:49:29 GMT, Lin Zang wrote:
> 8252842: Extend jmap to support parallel heap dump
This pull request has now been integrated.
Changeset: a74c099d
Author:Lin Zang
URL:
https://git.openjdk.java.net/jdk/commit/a74c099d67272b2ef542405d30db62a82cbbebc6
Stats:
On Fri, 17 Sep 2021 08:24:54 GMT, Lin Zang wrote:
> The class `GzipRandomAccess` is used to parse heap dump file generated from
> `jcmd`/`jmap` tools when testing.
> It has the limitation that only gzip file which has "blocksize" header field
> could be sucessfully p
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Thanks @schmelter-sap and @plummercj for your help review and appr
On Thu, 16 Sep 2021 09:35:20 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previ
The class `GzipRandomAccess` is used to parse heap dump file generated from
`jcmd`/`jmap` tools when testing.
It has the limitation that only gzip file which has "blocksize" header field
could be sucessfully parsed.
We think this class can be removed for 2 reasons:
1. The gzip heap
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Hi Ralf @schmelter-sap,
I have updated the PR, would you lik
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has refreshed the contents of this pull request, and previous commits
have been removed. The incremental views will show differences compared to the
previous content of the PR. The pull request contains one new commit since the
l
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix build issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: https://git.openjdk.java.
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code refine
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: https://git.openjdk.java.net/
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: https://git.openjdk.java.net/
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 49 commits:
- fix parallel issue
- Merge branch 'master' into pd-fix
- Merge branch 'master'
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
rebased with latest master, and ma
te over all static fields of the
> class. So I would avoid having to calculate the size twice (here and when we
> are actually dump it). Maybe here it would just be enough to use o->size() *
> 8 as an upper limit value of the real size in the heap dump. After all
> practically no no
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> I will start reviewing this today.
Hi Ralf @schmelter-sap ,
Thanks for your review and comments!
On Wed, 8 Sep 2021 13:39:08 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix build error
>
> src/hotspot/share/services/attachListener.cpp line 255:
>
>> 253: HeapDumper dumper(live_objects_
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
The change seems OK so far, but I&
On Fri, 10 Sep 2021 03:03:01 GMT, Lin Zang wrote:
> Seems the #5410 has made some change that will affect this one. I am
> wondering should I start to rebase this PR based on that ?
It looks like at most there would be one conflict, and it is trivial. You'll
eventually have to merge before int
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
Seems the #5410 has made some change
On Wed, 8 Sep 2021 05:02:18 GMT, Ralf Schmelter wrote:
> I will start reviewing this today.
Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Mon, 6 Sep 2021 08:03:22 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix build error
I will start reviewing this toda
On Thu, 28 Jan 2021 07:30:29 GMT, Serguei Spitsyn wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Hi Lin,
> It is also in my memory that you actually did not have 4 arguments.
> The real incompatibility issue was that the order of arguments was swapped.
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 40 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- f
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 39 commits:
- Merge branch 'master' into par-dump
- fix build issue
- Merge branch 'master'
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix build issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: https://git.openjdk.java.
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 37 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- Merge b
On Mon, 7 Jun 2021 07:58:26 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 36 commits:
>
> - Merge branch 'master
On Mon, 7 Jun 2021 07:58:26 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 36 commits:
>
> - Merge branch 'master
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 36 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- fix b
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 35 commits:
- Merge branch 'master' into par-dump
- fix build issue after rebase and fix one issue
-
On Wed, 19 May 2021 11:55:12 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 34 commits:
>
> - fix build issue after reb
On Mon, 10 May 2021 23:29:36 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine and typo fix
>
> I think you still need to undo the JMap.java changes since they are now being
> handled by #
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 34 commits:
- fix build issue after rebase and fix one issue
- Merge branch 'master'
- Merge branch &#x
On Wed, 12 May 2021 11:10:37 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 32 commits:
>
> - Merge branch 'm
On Wed, 12 May 2021 11:10:37 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 32 commits:
>
> - Merge branch 'm
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 32 commits:
- Merge branch 'master' into pd
- update copyright info
- Merge branch 'master'
On Tue, 11 May 2021 03:19:05 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 30 commits:
>
> - Merge branch 'maste
On Mon, 10 May 2021 23:29:36 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine and typo fix
>
> I think you still need to undo the JMap.java changes since they are now being
> handled by #
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 30 commits:
- Merge branch 'master' into par-dump
- undo JMap.java
- code refine and typo fix
- Merge b
On Thu, 6 May 2021 08:45:45 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine and typo fix
I think you still need
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code refine and typo fix
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: ht
On Mon, 26 Apr 2021 12:45:56 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 27 commits:
>
> - Merge branch &
On Mon, 26 Apr 2021 12:45:56 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 27 commits:
>
> - Merge branch &
On Mon, 26 Apr 2021 12:45:56 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 27 commits:
>
> - Merge branch &
On Wed, 21 Apr 2021 18:40:16 GMT, Chris Plummer wrote:
>>> My concerns with your proposed testing is that it always targets the same
>>> application with the same heap, and does not read/process the hprof file to
>>> make sure it is not corrupt.
>>
>> Hmm, I agree, I will do more test and upda
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 27 commits:
- Merge branch 'master' into par-dump
- refine with several fix
- Merge branch 'mas
On Tue, 20 Apr 2021 22:20:17 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into par-dump
>> - Merge branch 'master' into par-dump
>> - Typo fix
>
On Wed, 21 Apr 2021 18:40:16 GMT, Chris Plummer wrote:
> > > My concerns with your proposed testing is that it always targets the same
> > > application with the same heap, and does not read/process the hprof file
> > > to make sure it is not corrupt.
> >
> >
> > Hmm, I agree, I will do more
On Wed, 21 Apr 2021 05:56:21 GMT, Lin Zang wrote:
> > My concerns with your proposed testing is that it always targets the same
> > application with the same heap, and does not read/process the hprof file to
> > make sure it is not corrupt.
>
> Hmm, I agree, I will do more test and update here
On Wed, 21 Apr 2021 05:22:26 GMT, Chris Plummer wrote:
> My concerns with your proposed testing is that it always targets the same
> application with the same heap, and does not read/process the hprof file to
> make sure it is not corrupt.
Hmm, I agree, I will do more test and update here. Tha
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master
On Wed, 14 Apr 2021 12:35:27 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 25 commits:
>
> - Merge branch 'master
On Mon, 29 Mar 2021 11:27:49 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 24 commits:
>
> - Merge branch 'maste
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 25 commits:
- Merge branch 'master' into par-dump
- Merge branch 'master' into par-dump
- Typo
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 24 commits:
- Merge branch 'master' into par-dump
- Typo fix
- remove parallel option and dumpheapext comm
On Tue, 23 Mar 2021 23:33:02 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove parallel option and dumpheapext command
>> - Revert "hide the dumpheapext error message"
>>
>>This rever
On Mon, 22 Mar 2021 12:35:52 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - remove parallel option and dumpheapext command
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- remove parallel option and dumpheapext command
- Revert "hide the dumpheapext error message"
This r
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 20 commits:
- resize large object threshold
- Merge branch 'master' into par-dump
- Merge branch 'mas
he `parallel=` option for `jmap -dump` is complicated, it has to
>> consider the file writer threads and the disk writing speed. let me try to
>> explain the implementation briefly:
>>
>> In current implementation, the heap dump actaully has two kind of worker
>> th
On Thu, 18 Mar 2021 14:40:57 GMT, Lin Zang wrote:
> * Is it acceptable that `jmap -dump` and `jmap -histo` have different
> behavior about the option of `parallel`, that is, `heapdump` does not use it
> and `heaphisto` does.
And just to further clarify, the parallel support for `jmap -histo` i
me and then adjust the number.
- The `parallel=` option for `jmap -dump` is complicated, it has to consider
the file writer threads and the disk writing speed. let me try to explain the
implementation briefly:
In current implementation, the heap dump actaully has two kind of worker
threads -
On Thu, 18 Mar 2021 12:09:25 GMT, Ralf Schmelter wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reduce memory consumption and fix memory leak issue
>
> src/hotspot/share/services/heapDumper.cpp line 1741:
>
>> 1739:
On Thu, 18 Mar 2021 11:07:16 GMT, Lin Zang wrote:
>> Dear Ralf @schmelter-sap,
>> Sorry for late response, I got stuck in other work recently.
>> I have uploaded a new update that could help reduce memory consumption and
>> also fix the assertion issue.
>> I have verified it on my machine, May
On Wed, 10 Mar 2021 09:41:21 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reduce memory consumption and fix memory leak iss
e more about it~
>>
>> I would guess that is the case. In the compressed case we write about 800 MB
>> per second, that is as fast as my SSD goes.
>>
>> Here are some actual results I've gotten (uncompressed):
>>
>> jmap.exe -dump:file=ser.hpro
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 18 commits:
- Merge branch 'master' into par-dump
- code clean
- fix trailing white space issue
-
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code clean
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: https://git.openjdk.java.net/
t; per second, that is as fast as my SSD goes.
>
> Here are some actual results I've gotten (uncompressed):
>
> jmap.exe -dump:file=ser.hprof,all 30600
> Dumping heap to ser.hprof ...
> Heap dump file created [32009882362 bytes in 59.303 secs]
>
> jmap.exe -dum
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix trailing white space issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: ht
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
reduce memory consumption and fix memory leak issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/fi
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Revise jmap help info
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2261/files
- new: ht
> 8252842: Extend jmap to support parallel heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 13 commits:
- Merge master
- fix build fail issue on windows
- hide the dumpheapext error message
- Merge bra
On Thu, 25 Feb 2021 12:18:55 GMT, Lin Zang wrote:
> Do you think it is ok if I change the help message of `parallel` option
> `jmap -histo` in this PR together?
Yes, I think that would be ok.
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Wed, 24 Feb 2021 04:12:13 GMT, Chris Plummer wrote:
>>> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
>>> 3rd argument, but doesn't look at it. Maybe that was intentional to allow
>>> for a new argument without causing a failure. What it means is if we want a
>>
On Wed, 9 Dec 2020 08:51:48 GMT, Lin Zang wrote:
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
This pull request has now been integrated.
Changeset: c54724da
Author:Lin Zang
Committer: Jie Fu
URL: https://git.openjdk.java.net/jdk/commit/c54724da
Stats:
On Wed, 24 Feb 2021 04:12:13 GMT, Chris Plummer wrote:
>>> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
>>> 3rd argument, but doesn't look at it. Maybe that was intentional to allow
>>> for a new argument without causing a failure. What it means is if we want a
>>
On Sat, 20 Feb 2021 11:35:18 GMT, Lin Zang wrote:
>> Marked as reviewed by cjplummer (Reviewer).
>
> Mark it as ready for pushing. Thanks @plummercj @sspitsyn and @YaSuenag for
> help reviewing!
Dear All，
May I ask your help to push this PR as it is ready.
Thanks!
Lin
-
PR: https
ile APIs, so
No big changes are required in the heap dump code.
For domain sockets or named pipes you need another program
(like nc on Unix) which creates them and reads the output.
And I think this should not work be default, but only is requested
By the used via a flag or something.
Best regards,
Ralf
o the potential for accidents. One use-case at the time
for specifying an existing file was to append the dump to an existing
heap dump, meaning several heap dumps in the same file that could be
used for comparison purposes. We didn't go too far on extending the
hprof binary format to s
to be able to stream the heap dump directly to a
named pipe on Windows or a tty or domain socket on Unix, especially on systems with low
disk space. Since we now don't have the requirement to seek anymore, when we open the file
with os::create_binary_file(, true) instead of
os::create_bina
Hi,
as described in https://bugs.openjdk.java.net/browse/JDK-8200579 it could be
useful to be able to specify an already existing 'file' to be able to stream
the heap dump directly to a named pipe on Windows or a tty or domain socket on
Unix, especially on systems with low disk space
On Wed, 24 Feb 2021 03:46:42 GMT, Lin Zang wrote:
> > But they are far more convenient and easier to understand than jcmd, so
> > will probably stay around. But you are right in that they could still all
> > be converted to use jcmd internally.
>
> Maybe we could consider using `jcmd` internal
On Wed, 24 Feb 2021 02:48:06 GMT, Chris Plummer wrote:
> It's too bad that the `dumpheap` command in previous JDKs has a slot for a
> 3rd argument, but doesn't look at it. Maybe that was intentional to allow for
> a new argument without causing a failure. What it means is if we want a
> failur
On Wed, 24 Feb 2021 03:24:46 GMT, Lin Zang wrote:
> > JDK-8251347 does not appear to be the correct bug. Can you find the one you
> > are referring too?
>
> oops, It should be https://bugs.openjdk.java.net/browse/JDK-8251374, sorry.
Ok, but that fix is on the client side, not the target VM sid
On Wed, 24 Feb 2021 02:48:06 GMT, Chris Plummer wrote:
> JDK-8251347 does not appear to be the correct bug. Can you find the one you
> are referring too?
oops, It should be https://bugs.openjdk.java.net/browse/JDK-8251374, sorry.
-
PR: https://git.openjdk.java.net/jdk/pull/2261
On Wed, 24 Feb 2021 01:08:58 GMT, Lin Zang wrote:
>>> I just realized that my understand is a little different with the
>>> "retrying" - if we already know what is newly added argument, we can assume
>>> old jvm can not accept it. So it seems print error message is enough. This
>>> is consist
On Wed, 24 Feb 2021 00:40:03 GMT, Chris Plummer wrote:
>>> So in general, I think any solution we come up with will fail with older
>>> JDKs, and need to fallback to retrying with a command we know will work.
>>
>> Dear Chris,
>> I just realized that my understand is a little different with th
1 - 100 of 387 matches
Mail list logo
